All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
	akhilesh@ee.iitb.ac.in
Subject: Re: [PATCH] staging: vme_user: fix missing blank line after declaration
Date: Sun, 26 Apr 2026 21:04:49 +0200	[thread overview]
Message-ID: <2026042634-stonework-promenade-0a00@gregkh> (raw)
In-Reply-To: <20260418115858.5072-1-shyamsunderreddypadira@gmail.com>

On Sat, Apr 18, 2026 at 05:28:57PM +0530, Shyam Sunder Reddy Padira wrote:
> Fix checkpatch.pl warning regarding:
> -Missing a blank line after declaration
> 
> Add a blank line after variable declarations to comply
> with kernel coding style and improve code readability.
> 
> Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
> ---
>  drivers/staging/vme_user/vme_tsi148.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
> index f73ac92320bb..3102b94a0a86 100644
> --- a/drivers/staging/vme_user/vme_tsi148.h
> +++ b/drivers/staging/vme_user/vme_tsi148.h
> @@ -34,6 +34,7 @@ struct tsi148_driver {
>  	void __iomem *base;	/* Base Address of device registers */
>  	wait_queue_head_t dma_queue[2];
>  	wait_queue_head_t iack_queue;
> +
>  	void (*lm_callback[4])(void *);	/* Called in interrupt handler */
>  	void *lm_data[4];
>  	void *crcsr_kernel;
> -- 
> 2.43.0
> 
> 

This is a structure, not a function, checkpatch fooled you :(

  reply	other threads:[~2026-04-27  3:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-18 11:58 [PATCH] staging: vme_user: fix missing blank line after declaration Shyam Sunder Reddy Padira
2026-04-26 19:04 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-03-14 22:05 Giacomo Di Clerico
2026-03-15  6:54 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026042634-stonework-promenade-0a00@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=akhilesh@ee.iitb.ac.in \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=shyamsunderreddypadira@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.