From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BD93FF8868 for ; Mon, 27 Apr 2026 19:46:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHRtp-0000T1-2B; Mon, 27 Apr 2026 15:45:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRtn-0000CJ-BZ for qemu-arm@nongnu.org; Mon, 27 Apr 2026 15:45:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHRtl-0008QM-R3 for qemu-arm@nongnu.org; Mon, 27 Apr 2026 15:45:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777319141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TrJVVZU6/Vb8qTLcl1rdJM/fVCkqBrqY+cxIoO1k+u8=; b=KzW14a4F13iNVJUXT6DLgO3f6eiHl38T7tLjU20ka80uyWsmf4LSLRvkHKvZIgQvHYBCXs Bb0UmwroMMLDEQwF7lXEwsCdjNU4NN1LO+sn3X6+t87/WGewE5k3mi+KFstX6xAmXrIR3G 4J76uhBdGo8JDNQbZa12Wgix27Sk9wI= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-400-jdhpb1OVPYiS51WHP1gnmQ-1; Mon, 27 Apr 2026 15:45:34 -0400 X-MC-Unique: jdhpb1OVPYiS51WHP1gnmQ-1 X-Mimecast-MFC-AGG-ID: jdhpb1OVPYiS51WHP1gnmQ_1777319133 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EA0E01800EC6; Mon, 27 Apr 2026 19:45:32 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 137BB19560AB; Mon, 27 Apr 2026 19:45:30 +0000 (UTC) From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Apr 2026 23:42:30 +0400 Subject: [PATCH 31/41] hw/arm/aspeed: free fmc_model and spi_model on finalization MIME-Version: 1.0 Message-Id: <20260427-qom-tests-v1-31-c413f3605311@redhat.com> References: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> In-Reply-To: <20260427-qom-tests-v1-0-c413f3605311@redhat.com> To: qemu-devel@nongnu.org Cc: armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , Kane Chen , Andrew Jeffery , Joel Stanley , qemu-arm@nongnu.org X-Developer-Signature: v=1; a=openpgp-sha256; l=1317; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=QmEwAllDpvGZxHEBIiH8j7FQV0Uib/7g87F76P7ZxvM=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wV9VjLQBf/gHgH1FKdJL2Xn8D2iHAdgciYJ l6K3wXMshKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac 5c4sEACZaigFcm1E8MQN8NsoAQIovauBv5iv6cFaus+D6+fU767G9Zs7kc0nr2iWWVRFTuwGzZk YqNLBe6id+Pf4E7m+zyPMXbYLe42uqgSKXkSQEkSvayCrp/+W+33mHJLzeJlw2ZS65DsAuKwn5e W8xXmODioL8/X1lYcCLmXWWFLaf5R5KbkVyFFjJX7PzdLlnXf+cxdmuqYlBqztrDf0StboLKIgf 7osIkojRoMkWIegtouNvidYKxLPfc2qKy+Df4Xp6VdC1mM3sXDJ8TqL8iTLr0i/6/gBejWCiTwj jJ2h1imxulmhxr4Dl9eNyeT2VprRCzb+xPlCTE7K75KpeBSm0QZURjISalPzLkybi80WuEu+tGC U3fGZvwrY6F1zmDeMJNQjIOu5HDy/oH/uMmlGBSxcMKfeceUWkc1wA2J96Eb0PBVU6tFcLdfNId 7PZzcZkUOmrBQvKVZ/IKgOKIL3YtBnYehLHTqPwQL4OeGuclVFCNXzuW5bTLjMiETtFOm6vxizg 5MUe3Y1qjbknjVb9FBNk05dws6rIYS0NpHGWXWu+7cwNCUZTnpBquPk4Glpt/ENe7G0BJXmB+1N phiEMzPZnmLd2q8xtF7tG95fYvHZwFAKcNsZQ2N0GmLDOLjp6P+MQ6F7XrnKmJXFt1rmGl7Qw+i wFsKC+lZ7QfVI3A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-MFC-PROC-ID: ieJKmw7dTb8AMC-oXSL22Kx09LVUQMjUrDzFnIRginA_1777319133 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org The fmc_model and spi_model strings are allocated via g_strdup in property setters but never freed when the machine object is destroyed. Fixes: 9820e52fbef7 ("hw/arm/aspeed: Add machine properties to define the flash models") Signed-off-by: Marc-André Lureau --- hw/arm/aspeed.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index a3db3406c5f..a48c4420583 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -419,12 +419,21 @@ static void aspeed_machine_class_init(ObjectClass *oc, const void *data) aspeed_machine_class_props_init(oc); } +static void aspeed_machine_instance_finalize(Object *obj) +{ + AspeedMachineState *bmc = ASPEED_MACHINE(obj); + + g_free(bmc->fmc_model); + g_free(bmc->spi_model); +} + static const TypeInfo aspeed_machine_types[] = { { .name = TYPE_ASPEED_MACHINE, .parent = TYPE_MACHINE, .instance_size = sizeof(AspeedMachineState), .instance_init = aspeed_machine_instance_init, + .instance_finalize = aspeed_machine_instance_finalize, .class_size = sizeof(AspeedMachineClass), .class_init = aspeed_machine_class_init, .abstract = true, -- 2.53.0