From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 2/2] Add new test ioctl_getlbmd01
Date: Mon, 27 Apr 2026 10:22:19 +0200 [thread overview]
Message-ID: <20260427082219.GA828163@pevik> (raw)
In-Reply-To: <20260325-ioctl_getlbmd01-v1-2-00dc526e326f@suse.com>
Hi Andrea,
LGTM, thanks!
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> +static struct tst_test test = {
> + .test_all = run,
> + .setup = setup,
> + .cleanup = cleanup,
> + .needs_device = 1,
> + .needs_root = 1,
> + .needs_tmpdir = 1,
nit: This is not needed due needs_device (see needs_tmpdir()).
(can be fixed before merge.
Kind regards,
Petr Vorel
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-04-27 8:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 14:19 [LTP] [PATCH 0/2] New test for ioctl(FS_IOC_GETLBMD_CAP) feature Andrea Cervesato
2026-03-25 14:19 ` [LTP] [PATCH 1/2] Add logical_block_metadata_cap struct fallback Andrea Cervesato
2026-04-27 8:25 ` Petr Vorel
2026-05-06 12:58 ` [LTP] " linuxtestproject.agent
2026-05-06 13:10 ` [LTP] [PATCH 1/2] " Andrea Cervesato via ltp
2026-03-25 14:19 ` [LTP] [PATCH 2/2] Add new test ioctl_getlbmd01 Andrea Cervesato
2026-04-27 8:22 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427082219.GA828163@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.