From: Thorsten Blum <thorsten.blum@linux.dev>
To: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Willem de Bruijn <willemb@google.com>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Thorsten Blum <thorsten.blum@linux.dev>
Subject: [PATCH 6/6] crypto: algif_skcipher - use sock_kzalloc in accept_parent_nokey
Date: Mon, 27 Apr 2026 12:41:35 +0200 [thread overview]
Message-ID: <20260427104129.309982-12-thorsten.blum@linux.dev> (raw)
In-Reply-To: <20260427104129.309982-7-thorsten.blum@linux.dev>
Replace sock_kmalloc() followed by memset(0) with sock_kzalloc() to
simplify skcipher_accept_parent_nokey().
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
crypto/algif_skcipher.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/crypto/algif_skcipher.c b/crypto/algif_skcipher.c
index ba0a17fd95ac..f29a304e1268 100644
--- a/crypto/algif_skcipher.c
+++ b/crypto/algif_skcipher.c
@@ -383,18 +383,15 @@ static int skcipher_accept_parent_nokey(void *private, struct sock *sk)
struct crypto_skcipher *tfm = private;
unsigned int len = sizeof(*ctx);
- ctx = sock_kmalloc(sk, len, GFP_KERNEL);
+ ctx = sock_kzalloc(sk, len, GFP_KERNEL);
if (!ctx)
return -ENOMEM;
- memset(ctx, 0, len);
- ctx->iv = sock_kmalloc(sk, crypto_skcipher_ivsize(tfm),
- GFP_KERNEL);
+ ctx->iv = sock_kzalloc(sk, crypto_skcipher_ivsize(tfm), GFP_KERNEL);
if (!ctx->iv) {
sock_kfree_s(sk, ctx, len);
return -ENOMEM;
}
- memset(ctx->iv, 0, crypto_skcipher_ivsize(tfm));
INIT_LIST_HEAD(&ctx->tsgl_list);
ctx->len = len;
next prev parent reply other threads:[~2026-04-27 10:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 10:41 [PATCH 1/6] sock: add sock_kzalloc helper Thorsten Blum
2026-04-27 10:41 ` [PATCH 2/6] crypto: af_alg - use sock_kzalloc in af_alg_alloc_areq Thorsten Blum
2026-04-28 20:08 ` Kuniyuki Iwashima
2026-04-27 10:41 ` [PATCH 3/6] crypto: algif_aead - use sock_kzalloc in aead_accept_parent_nokey Thorsten Blum
2026-04-28 20:08 ` Kuniyuki Iwashima
2026-04-27 10:41 ` [PATCH 4/6] crypto: af_alg - use sock_kzalloc in alloc_result + accept_parent_nokey Thorsten Blum
2026-04-28 20:09 ` Kuniyuki Iwashima
2026-04-27 10:41 ` [PATCH 5/6] crypto: algif_rng - use sock_kzalloc in rng_accept_parent Thorsten Blum
2026-04-28 20:09 ` Kuniyuki Iwashima
2026-04-27 10:41 ` Thorsten Blum [this message]
2026-04-28 20:09 ` [PATCH 6/6] crypto: algif_skcipher - use sock_kzalloc in accept_parent_nokey Kuniyuki Iwashima
2026-04-28 20:07 ` [PATCH 1/6] sock: add sock_kzalloc helper Kuniyuki Iwashima
2026-05-22 12:50 ` Thorsten Blum
2026-05-26 9:14 ` Herbert Xu
2026-05-26 13:23 ` Thorsten Blum
2026-05-26 22:57 ` Jakub Kicinski
2026-05-26 14:17 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427104129.309982-12-thorsten.blum@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.