From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
Kuniyuki Iwashima <kuniyu@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 2/4] net/sched: tc_dump_qdisc_root() refactor
Date: Mon, 27 Apr 2026 16:08:47 -0700 [thread overview]
Message-ID: <20260427160847.5dbf1915@kernel.org> (raw)
In-Reply-To: <20260427132555.1791636-3-edumazet@google.com>
On Mon, 27 Apr 2026 13:25:53 +0000 Eric Dumazet wrote:
> - if (q_idx < s_q_idx) {
> - q_idx++;
> - } else {
> - if (!tc_qdisc_dump_ignore(q, dump_invisible) &&
> - tc_fill_qdisc(skb, q, q->parent, NETLINK_CB(cb->skb).portid,
> - cb->nlh->nlmsg_seq, NLM_F_MULTI,
> - RTM_NEWQDISC, NULL) <= 0)
> - goto done;
> - q_idx++;
> + if (!(q_idx < s_q_idx) &&
> + !tc_qdisc_dump_ignore(q, dump_invisible)) {
> + ret = tc_fill_qdisc(skb, q, q->parent,
> + NETLINK_CB(cb->skb).portid,
> + cb->nlh->nlmsg_seq, NLM_F_MULTI,
> + RTM_NEWQDISC, NULL);
> + if (ret < 0)
> + goto out;
> }
> + q_idx++;
Probably subjective but I'm not sure the
if (!(q_idx < s_q_idx) &&
is more readable than the previous version?
Especially for:
> hash_for_each(qdisc_dev(root)->qdisc_hash, b, q, hash) {
> - if (q_idx < s_q_idx) {
> - q_idx++;
> - continue;
> + if (!(q_idx < s_q_idx) &&
> + !tc_qdisc_dump_ignore(q, dump_invisible)) {
> + ret = tc_fill_qdisc(skb, q, q->parent,
> + NETLINK_CB(cb->skb).portid,
> + cb->nlh->nlmsg_seq, NLM_F_MULTI,
> + RTM_NEWQDISC, NULL);
> + if (ret < 0)
> + goto out;
> }
I feel like checking the ID + continue in netlink dump loop is fairly
idiomatic.
next prev parent reply other threads:[~2026-04-27 23:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 13:25 [PATCH net-next 0/4] net/sched: tc_dump_qdisc() optimizations Eric Dumazet
2026-04-27 13:25 ` [PATCH net-next 1/4] net/sched: propagate tc_fill_tclass() error Eric Dumazet
2026-04-27 13:25 ` [PATCH net-next 2/4] net/sched: tc_dump_qdisc_root() refactor Eric Dumazet
2026-04-27 23:08 ` Jakub Kicinski [this message]
2026-04-28 15:48 ` Eric Dumazet
2026-04-27 13:25 ` [PATCH net-next 3/4] net/sched: switch tc_dump_qdisc() to for_each_netdev_dump() Eric Dumazet
2026-04-27 23:13 ` Jakub Kicinski
2026-04-28 15:57 ` Eric Dumazet
2026-04-27 13:25 ` [PATCH net-next 4/4] net/sched: speedup tc_dump_qdisc() when tcm_ifindex is provided Eric Dumazet
2026-04-27 23:18 ` Jakub Kicinski
2026-04-28 15:40 ` Eric Dumazet
2026-04-28 17:20 ` Jakub Kicinski
2026-04-28 17:26 ` Eric Dumazet
2026-04-27 23:02 ` [PATCH net-next 0/4] net/sched: tc_dump_qdisc() optimizations Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427160847.5dbf1915@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.