All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Berry <kpberry@google.com>
To: xmei5@asu.edu
Cc: bestswngs@gmail.com, chenglongtang@google.com,
	joneslee@google.com,  kpberry@google.com, pabeni@redhat.com,
	rnj@google.com, stable@vger.kernel.org
Subject: Re: [PATCH 6.12.y] net: bonding: fix use-after-free in bond_xmit_broadcast()
Date: Mon, 27 Apr 2026 18:42:06 +0000	[thread overview]
Message-ID: <20260427184208.161981-1-kpberry@google.com> (raw)
In-Reply-To: <CAPpSM+SbRsFUd9jcP81K1VmhANhT7uzPqOPmy8i0gZ28ctjQKw@mail.gmail.com>

Hi Xiang,

> I was wondering if it might be sufficient to apply my original
> patch instead. I’ve also checked against 6.12.81 and didn’t encounter
> any conflicts.

We tried applying your original patch first, but, while it does apply
cleanly, it doesn't compile because the version of bond_xmit_broadcast
in the 6.12 kernel doesn't have the slaves_count variable introduced
in ce7a381697cb.

> Could you please clarify the need for the parameter bool all_slaves?

We had included the all_slaves parameter to try to reduce the chance of
conflicts with any other potential backports from later kernel versions,
but I agree that omitting it is probably better.

I've sent an amended version of the patch which just adds slaves_count,
uses an explicit loop, and applies your original change. Tested the
patch by compiling it.


Thanks,

Kevin

  reply	other threads:[~2026-04-27 18:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13 21:34 [PATCH 6.12.y] net: bonding: fix use-after-free in bond_xmit_broadcast() Chenglong Tang
2026-04-13 21:54 ` Xiang Mei
2026-04-27 18:42   ` Kevin Berry [this message]
2026-04-27 18:42     ` [PATCH] " Kevin Berry
2026-04-27 20:07       ` Xiang Mei
2026-04-27 21:06         ` Kevin Berry
  -- strict thread matches above, loose matches on Subject: below --
2026-04-10 21:09 [PATCH 6.12.y] " Chenglong Tang
2026-04-13 11:51 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260427184208.161981-1-kpberry@google.com \
    --to=kpberry@google.com \
    --cc=bestswngs@gmail.com \
    --cc=chenglongtang@google.com \
    --cc=joneslee@google.com \
    --cc=pabeni@redhat.com \
    --cc=rnj@google.com \
    --cc=stable@vger.kernel.org \
    --cc=xmei5@asu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.