From: Gunnar Kudrjavets <gunnarku@amazon.com>
To: <pmenzel@molgen.mpg.de>
Cc: <peterhuewe@gmx.de>, <jarkko@kernel.org>, <jgg@ziepe.ca>,
<noodles@meta.com>, <linux-integrity@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <jbouron@amazon.com>,
<gunnarku@amazon.com>
Subject: Re: [PATCH] tpm: Remove dead NULL check in tpm2_flush_space()
Date: Mon, 27 Apr 2026 22:57:03 +0000 [thread overview]
Message-ID: <20260427225722.17878-1-gunnarku@amazon.com> (raw)
In-Reply-To: <e71c6d95-6c83-4fb4-8cd5-f66067fb68c5@molgen.mpg.de>
On Sun, Apr 27, 2026 at 10:49 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
> gemini/gemini-3.1-pro-preview made a comment [1]. No idea, if it's valid.
Thanks for forwarding, Paul. AFAICS, the comment is a false positive.
My theory is that Gemini conflates two different variables named
'space':
1. The 'space' parameter passed to tpm_dev_transmit(). This *can* be
NULL (it is NULL for /dev/tpm0 clients).
2. The local 'space' variable inside tpm2_flush_space(). This is
assigned from &chip->work_space and can *never* be NULL.
The removed NULL check was testing case (2), not case (1).
Regards,
Gunnar
next prev parent reply other threads:[~2026-04-27 22:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 16:32 [PATCH] tpm: Remove dead NULL check in tpm2_flush_space() Gunnar Kudrjavets
2026-04-27 20:49 ` Paul Menzel
2026-04-27 22:57 ` Gunnar Kudrjavets [this message]
2026-04-28 6:18 ` Paul Menzel
2026-05-09 12:26 ` Jarkko Sakkinen
2026-05-09 11:28 ` Jarkko Sakkinen
2026-05-09 11:38 ` Jarkko Sakkinen
2026-05-09 22:54 ` Gunnar Kudrjavets
2026-05-10 1:40 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427225722.17878-1-gunnarku@amazon.com \
--to=gunnarku@amazon.com \
--cc=jarkko@kernel.org \
--cc=jbouron@amazon.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noodles@meta.com \
--cc=peterhuewe@gmx.de \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.