From: Ethan Nelson-Moore <enelsonmoore@gmail.com>
To: macro@orcam.me.uk
Cc: andrew@lunn.ch, enelsonmoore@gmail.com, horms@kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] docs: 3c509: remove note about card detection failing with overclock
Date: Mon, 27 Apr 2026 22:20:03 -0700 [thread overview]
Message-ID: <20260428052003.66510-2-enelsonmoore@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2601260039220.40317@angie.orcam.me.uk>
Hi, Maciej,
Sorry for the extreme delay in responding - I somehow missed this message.
On 26 Jan 2026 Maciej W. Rozycki wrote:
> -- so it's not about using a time-based vs some other kind of delay. The
> comment to be removed was only added along with the whole document on the
> 3c509 driver with Linux 2.5.13, much later (2002 vs 1998), and therefore
> still stands.
I traced back the usage of udelay in this driver and found that id_read_eeprom
did in fact use a busy waiting loop before kernel 2.0.14:
https://github.com/schwabe/davej-history/commit/8cf64f0c94dcbf029dc3b12cb8e2afba590f8f72#diff-9acb56ec07fd10ccce51b1dc719976d60ee5a947dec31174e2a96f871fde72f9L331
This is probably what the comment was referring to, and therefore it is in fact
incorrect. The documentation appears to have been imported from the Scyld
out-of-tree driver (the basis of the mainline driver), which still mentioned the
issue in 2003:
https://web.archive.org/web/20030605134029/http://www.scyld.com/network/3c509.html
I was not able to find a copy of an old Scyld driver easily to see if it was
affected by the issue.
Hope that clarifies the situation.
Ethan
next prev parent reply other threads:[~2026-04-28 5:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 7:11 [PATCH net-next] docs: 3c509: remove note about card detection failing with overclock Ethan Nelson-Moore
2026-01-09 18:01 ` Simon Horman
2026-01-25 7:21 ` Ethan Nelson-Moore
2026-01-25 16:32 ` Andrew Lunn
2026-01-26 1:04 ` Maciej W. Rozycki
2026-04-28 5:20 ` Ethan Nelson-Moore [this message]
2026-05-20 11:20 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428052003.66510-2-enelsonmoore@gmail.com \
--to=enelsonmoore@gmail.com \
--cc=andrew@lunn.ch \
--cc=horms@kernel.org \
--cc=macro@orcam.me.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.