Re: [PATCH v4 02/20] drm/tyr: select required dependencies in Kconfig

[Boris Brezillon <boris.brezillon@collabora.com>]

On Mon, 27 Apr 2026 16:36:48 -0700
Deborah Brouwer <deborah.brouwer@collabora.com> wrote:

> On Mon, Apr 27, 2026 at 09:23:38AM +0200, Boris Brezillon wrote:
> > On Fri, 24 Apr 2026 16:38:56 -0700
> > Deborah Brouwer <deborah.brouwer@collabora.com> wrote:
> >   
> > > From: Boris Brezillon <boris.brezillon@collabora.com>
> > > 
> > > Tyr depends on DRM_GPUVM, RUST_DRM_GEM_SHMEM_HELPER, MMU, IOMMU_SUPPORT,
> > > and IOMMU_IO_PGTABLE_LPAE. Select or depend on these symbols in Kconfig so
> > > the required infrastructure is enabled when Tyr is built.
> > > 
> > > Introduce DRM_TYR_STATIC_DEPS to keep the built-in DRM dependencies
> > > selected even when Tyr is built as a module.
> > > 
> > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> > > Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
> > > ---
> > >  drivers/gpu/drm/tyr/Kconfig | 14 +++++++++++++-
> > >  1 file changed, 13 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/tyr/Kconfig b/drivers/gpu/drm/tyr/Kconfig
> > > index e933e6478027..443ce988b570 100644
> > > --- a/drivers/gpu/drm/tyr/Kconfig
> > > +++ b/drivers/gpu/drm/tyr/Kconfig
> > > @@ -1,5 +1,12 @@
> > >  # SPDX-License-Identifier: GPL-2.0 or MIT
> > >  
> > > +config DRM_TYR_STATIC_DEPS
> > > +	bool
> > > +	select DRM_GPUVM  
> > 
> > IIRC, Danilo said we should have some boolean RUST_DRM_GPUVM option
> > selecting DRM_GPUVM for us, just like RUST_DRM_GEM_SHMEM_HELPER does.  
> 
> yes, I think Alice just sent that patch today. I have fixed it and
> will send it in the next version.

BTW, I don't think the deps should be added in their own commit, but
rather be part of the commit that starts using those deps:

- select RUST_DRM_GEM_SHMEM_HELPER in patch 5
- select IOMMU_IO_PGTABLE_LPAE, DRM_GPUVM and depends on IOMMU_SUPPORT
  in patch 10