Re: [LTP] [PATCH v5 5/6] lib: Merge functionality of LTP_QUIET into LTP_REPRODUCIBLE_OUTPUT

[Petr Vorel <pvorel@suse.cz>]

Hi Martin,

any change I'd get your explicit ack to this change
(your Acked-by: or Reviewed-by: ?). It should be safe for Valgrind, but better
you to double check.

https://lore.kernel.org/ltp/20260423084123.657690-6-pvorel@suse.cz/
https://patchwork.ozlabs.org/project/ltp/patch/20260423084123.657690-7-pvorel@suse.cz/

> LTP_REPRODUCIBLE_OUTPUT=1 environment variable was added in 5894abc5f to
> help valgrind to use LTP for testing. It discards the actual content of
> the messages printed by the test (removes everything after printing
> TINFO/TPASS/TFAIL/... flag).

> Later LTP_QUIET=1 was added which suppresses printing TCONF, TINFO, and
> TDEBUG messages.

> Valgrind project uses both variables but no need to handle them
> separately. Therefore merge functionality of LTP_QUIET into
> LTP_REPRODUCIBLE_OUTPUT.

> LTP_QUIET was not even documented in HTML doc.

> Also fix help description, because TWARN was not skipped, although doc
> claimed to do.

> Implements: https://github.com/linux-test-project/ltp/issues/1306
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Changes v4->v5:
> * Remove wrongly stated TWARN (error on code on master)
> * Fix missing new lines in help (AI)
> * Use single fprintf (Li)

>  doc/users/setup_tests.rst |  5 +++--
>  lib/tst_test.c            | 16 +++++-----------
>  2 files changed, 8 insertions(+), 13 deletions(-)

> diff --git a/doc/users/setup_tests.rst b/doc/users/setup_tests.rst
> index 6f1d996e18..491a5b003a 100644
> --- a/doc/users/setup_tests.rst
> +++ b/doc/users/setup_tests.rst
> @@ -43,8 +43,9 @@ users.
>         Shell language: ``TST_NEEDS_DEVICE=1``.

>     * - LTP_REPRODUCIBLE_OUTPUT
> -     - When set to ``1`` or ``y`` discards the actual content of the messages
> -       printed by the test (suitable for a reproducible output).
> +     - When set to ``1`` or ``y`` uppress printing TCONF, TINFO and TDEBUG
Also AI found missing 's': s/uppress/suppress/
I'll fix that before merging.

Kind regards,
Petr

> +       messages and discards the actual content of the other messages printed
> +       by the test (suitable for a reproducible output).
...

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp