From: Jakub Kicinski <kuba@kernel.org>
To: Dragos Tatulea <dtatulea@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Björn Töpel" <bjorn@kernel.org>,
"Martin Karsten" <mkarsten@uwaterloo.ca>,
"Gal Pressman" <gal@nvidia.com>,
"Tariq Toukan" <tariqt@nvidia.com>, "Joe Damato" <joe@dama.to>,
"Frederik Deweerdt" <fdeweerdt@fastly.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net-next 1/2] net: napi: Fix interrupts permanently disabled during busy poll
Date: Tue, 28 Apr 2026 17:38:44 -0700 [thread overview]
Message-ID: <20260428173844.1354aabe@kernel.org> (raw)
In-Reply-To: <20260428175134.1197036-3-dtatulea@nvidia.com>
On Tue, 28 Apr 2026 17:51:30 +0000 Dragos Tatulea wrote:
> + local_irq_save(flags);
> + hrtimer_start(&napi->timer, ns_to_ktime(timeout),
> + HRTIMER_MODE_REL_PINNED);
> clear_bit(NAPI_STATE_SCHED, &napi->state);
> + local_irq_restore(flags);
I don't think disabling IRQ is necessary?
Isn't it legal to clear the bit first then schedule the timer?
The timer does not own the napi instance.
next prev parent reply other threads:[~2026-04-29 0:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 17:51 [RFC PATCH net-next 0/2] net: napi: Fix timer arming during busy poll timeout Dragos Tatulea
2026-04-28 17:51 ` [RFC PATCH net-next 1/2] net: napi: Fix interrupts permanently disabled during busy poll Dragos Tatulea
2026-04-28 23:40 ` Jakub Kicinski
2026-04-29 0:04 ` Martin Karsten
2026-04-29 0:31 ` Jakub Kicinski
2026-04-29 8:13 ` Dragos Tatulea
2026-04-29 22:52 ` Jakub Kicinski
2026-04-29 0:38 ` Jakub Kicinski [this message]
2026-04-29 8:43 ` Dragos Tatulea
2026-04-29 12:13 ` Björn Töpel
2026-04-29 12:43 ` Dragos Tatulea
2026-05-04 11:30 ` Dragos Tatulea
2026-05-05 1:00 ` Jakub Kicinski
2026-04-28 17:51 ` [RFC PATCH net-next 2/2] net: napi: Skip poll when arming GRO timer in " Dragos Tatulea
2026-04-29 0:37 ` Jakub Kicinski
2026-04-29 1:02 ` Martin Karsten
2026-04-29 12:37 ` Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428173844.1354aabe@kernel.org \
--to=kuba@kernel.org \
--cc=bjorn@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=fdeweerdt@fastly.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=joe@dama.to \
--cc=linux-kernel@vger.kernel.org \
--cc=mkarsten@uwaterloo.ca \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.