From: Simon Horman <horms@kernel.org>
To: Prathamesh Deshpande <prathameshdeshpande7@gmail.com>
Cc: saeedm@nvidia.com, leon@kernel.org, kuba@kernel.org,
tariqt@nvidia.com, cratiu@nvidia.com, cjubran@nvidia.com,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v1] net/mlx5: Fix eswitch offloads cleanup on QoS init failure
Date: Tue, 28 Apr 2026 19:11:31 +0100 [thread overview]
Message-ID: <20260428181131.GV900403@horms.kernel.org> (raw)
In-Reply-To: <20260425003046.6889-1-prathameshdeshpande7@gmail.com>
On Sat, Apr 25, 2026 at 01:29:59AM +0100, Prathamesh Deshpande wrote:
> If mlx5_esw_qos_init() fails after esw_offloads_init() succeeds,
> mlx5_eswitch_init() jumps to reps_err and skips esw_offloads_cleanup(),
> leaking the offloads initialization state.
>
> Add a dedicated unwind label for QoS init failure that cleans up
> offloads before continuing the existing vport and outer eswitch cleanup.
>
> Fixes: cac7356c653d ("net/mlx5: Rework esw qos domain init and cleanup")
> Signed-off-by: Prathamesh Deshpande <prathameshdeshpande7@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2026-04-28 18:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-25 0:29 [PATCH net v1] net/mlx5: Fix eswitch offloads cleanup on QoS init failure Prathamesh Deshpande
2026-04-28 18:11 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428181131.GV900403@horms.kernel.org \
--to=horms@kernel.org \
--cc=cjubran@nvidia.com \
--cc=cratiu@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=prathameshdeshpande7@gmail.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.