Re: [PATCH v7 2/3] dt-bindings: hwmon: emc2305: Add fan-shutdown-percent property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `fan-shutdown-percent` property is redefined locally in the emc2305 binding instead of being moved to the common fan schema.
--

commit 0de7c28110f8526177da5d5c1903c8b485eec6ec
Author: Florin Leotescu <florin.leotescu@nxp.com>

dt-bindings: hwmon: emc2305: Add fan-shutdown-percent property

The EMC2305 fan controller supports multiple independent PWM fan
outputs. Some systems require fans to enter a defined safe state
during system shutdown or reboot handoff.

> diff --git a/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml b/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml
> index d3f06ebc19fa..8c2548539d7f 100644
> --- a/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml
> @@ -54,6 +54,12 @@ patternProperties:
>            The fan number used to determine the associated PWM channel.
>          maxItems: 1
>  
> +      fan-shutdown-percent:

This isn't a bug, but should this property be moved to the common fan
schema instead of being defined locally here?

The fan-shutdown-percent property already exists in
Documentation/devicetree/bindings/hwmon/pwm-fan.yaml to represent the same
hardware behavior. Unifying this property in fan-common.yaml would prevent
schema fragmentation and serve as a single source of truth, especially since
microchip,emc2305.yaml already references fan-common.yaml# for its child
nodes.

> +        description:
> +          PWM duty cycle in percent applied to the fan during shutdown.
> +        minimum: 0
> +        maximum: 100
> +

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260429065955.2113012-1-florin.leotescu@oss.nxp.com?part=2