Re: [LTP] clock_settime: use POSIX runtime detection for CLOCK_MONOTONIC

[linuxtestproject.agent@gmail.com]

Hi Andrea,

On Wed, 29 Apr 2026 10:28:35 +0200, Andrea Cervesato wrote:
> clock_settime: use POSIX runtime detection for CLOCK_MONOTONIC

> +/*
> + * Copyright (c) 2026, Linux Test Project
> + * SPDX-License-Identifier: GPL-2.0-or-later
> + */

Missing `Created by:` attribution line. Other headers in this directory
(posixtest.h, mq_send.h) carry it. Add:
  * Created by: Andrea Cervesato <andrea.cervesato@suse.com>

[...]

Pre-existing issues noticed in the surrounding code (not introduced
by this patch):

- clock_settime/4-1.c (and siblings) — uses `test_main` instead of `int main`
- clock_settime/helpers.h — `getBeforeTime()`/`setBackTime()` call perror()
  without including <stdio.h> in the header itself

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://github.com/linux-test-project/ltp-agent/actions/runs/25102778503

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp