From: Jakub Kicinski <kuba@kernel.org>
To: achender@kernel.org
Cc: netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com,
horms@kernel.org, linux-rdma@vger.kernel.org,
linux-kselftest@vger.kernel.org, shuah@kernel.org
Subject: Re: [PATCH net-next v2 5/7] selftests: rds: Fix gcov and pcap collection
Date: Wed, 29 Apr 2026 19:48:06 -0700 [thread overview]
Message-ID: <20260429194806.6ae176a9@kernel.org> (raw)
In-Reply-To: <20260430024206.2452353-1-kuba@kernel.org>
On Wed, 29 Apr 2026 19:42:06 -0700 Jakub Kicinski wrote:
> > +# tcpdump saves pcaps to /tmp because it requires chown to save the
> > +# pcap but chown is not supported by 9p. Mount tmpfs on /tmp if it is
> > +# not already a separate filesystem
> > +if ! mountpoint -q /tmp 2>/dev/null; then
> > + mount -t tmpfs tmpfs /tmp
> > +fi
> > +
>
> Could this introduce a regression when the test is run directly on a host
> workstation rather than inside an isolated VM?
>
> If /tmp is a regular directory on the root filesystem, mounting tmpfs over it
> will instantly hide all existing files and UNIX domain sockets in /tmp.
>
> Since there is no cleanup trap to unmount it on exit or failure, does this
> leave the host system in a degraded state?
I share Sashiko's mixed feelings here. Do other tests mount /tmp ?
Seems like something that belongs in the "CI setup", external
to ksft itself.
point #2 my vng does have an overlayfs mounted over /tmp so the
mountpoint check doesn't trigger IDK if this is what you meant
or I have a different version.
next prev parent reply other threads:[~2026-04-30 2:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 22:27 [PATCH net-next v2 0/7] selftests: rds: Log collection, TAP compliance and cleanups Allison Henderson
2026-04-28 22:27 ` [PATCH net-next v2 1/7] selftests: rds: Increase selftest timeout Allison Henderson
2026-04-28 22:27 ` [PATCH net-next v2 2/7] selftests: rds: Update USAGE string for run.sh Allison Henderson
2026-04-28 22:27 ` [PATCH net-next v2 3/7] selftests: rds: Fix more pylint errors Allison Henderson
2026-04-28 22:27 ` [PATCH net-next v2 4/7] selftests: rds: Add timeout flag to run.sh Allison Henderson
2026-04-28 22:27 ` [PATCH net-next v2 5/7] selftests: rds: Fix gcov and pcap collection Allison Henderson
2026-04-30 2:42 ` Jakub Kicinski
2026-04-30 2:48 ` Jakub Kicinski [this message]
2026-05-02 5:43 ` Allison Henderson
2026-05-02 16:38 ` Jakub Kicinski
2026-05-03 20:49 ` Allison Henderson
2026-04-28 22:27 ` [PATCH net-next v2 6/7] selftests: rds: Collect pcaps on timeout Allison Henderson
2026-04-30 2:42 ` Jakub Kicinski
2026-05-02 5:41 ` Allison Henderson
2026-04-28 22:27 ` [PATCH net-next v2 7/7] selftests: rds: Make rds selftests TAP compliant Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260429194806.6ae176a9@kernel.org \
--to=kuba@kernel.org \
--cc=achender@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.