All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Matthew Rosato" <mjrosato@linux.ibm.com>,
	"Cornelia Huck" <cohuck@redhat.com>
Subject: [PULL v2 03/11] target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (mmu)
Date: Thu, 30 Apr 2026 18:02:59 +0200	[thread overview]
Message-ID: <20260430160307.634093-4-cohuck@redhat.com> (raw)
In-Reply-To: <20260430160307.634093-1-cohuck@redhat.com>

From: Philippe Mathieu-Daudé <philmd@linaro.org>

Prefer the address_space_ld/st API over the legacy ld_phys()
because it allow checking for bus access fault.
This code however doesn't check for fault, so we simply inline
the calls (not specifying any memory transaction attribute nor
expecting transation result). No logical change intended.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
Tested-by: Matthew Rosato <mjrosato@linux.ibm.com>
Message-ID: <20260319185203.11799-3-philmd@linaro.org>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 target/s390x/mmu_helper.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
index 246573ff6429..255271b9d340 100644
--- a/target/s390x/mmu_helper.c
+++ b/target/s390x/mmu_helper.c
@@ -44,8 +44,9 @@ static void trigger_access_exception(CPUS390XState *env, uint32_t type,
     } else {
         CPUState *cs = env_cpu(env);
         if (type != PGM_ADDRESSING) {
-            stq_be_phys(cs->as, env->psa + offsetof(LowCore, trans_exc_code),
-                        tec);
+            address_space_stq_be(cs->as,
+                                 env->psa + offsetof(LowCore, trans_exc_code),
+                                 tec, MEMTXATTRS_UNSPECIFIED, NULL);
         }
         trigger_pgm_exception(env, type);
     }
-- 
2.53.0



  parent reply	other threads:[~2026-04-30 16:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30 16:02 [PULL v2 00/11] First batch of s390x updates for 11.1 Cornelia Huck
2026-04-30 16:02 ` [PULL v2 01/11] target/s390x/kvm: Simplify the async pfault handling code Cornelia Huck
2026-04-30 16:02 ` [PULL v2 02/11] target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (cpu) Cornelia Huck
2026-04-30 16:02 ` Cornelia Huck [this message]
2026-04-30 16:03 ` [PULL v2 04/11] target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (tcg) Cornelia Huck
2026-04-30 16:03 ` [PULL v2 05/11] target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (kvm) Cornelia Huck
2026-04-30 16:03 ` [PULL v2 06/11] configs/targets: Restrict the legacy ldst_phys() API on s390x target Cornelia Huck
2026-04-30 16:03 ` [PULL v2 07/11] tests/functional/s390x: Add test for booting from a disk with 4k sectors Cornelia Huck
2026-04-30 16:03 ` [PULL v2 08/11] target/s390x: Prefer MO_128 definition over magic value Cornelia Huck
2026-04-30 16:03 ` [PULL v2 09/11] MAINTAINERS: Update s390 trees Cornelia Huck
2026-04-30 16:03 ` [PULL v2 10/11] hw/s390x/ccw: Disable legacy virtio-pci by default (v11.1+) Cornelia Huck
2026-04-30 16:03 ` [PULL v2 11/11] tests/functional/s390x: Update expected virtio-pci IDs Cornelia Huck
2026-05-02 10:49 ` [PULL v2 00/11] First batch of s390x updates for 11.1 Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260430160307.634093-4-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.