All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: hawk@kernel.org
Cc: netdev@vger.kernel.org, kernel-team@cloudflare.com,
	"Jonas Köppeler" <j.koeppeler@tu-berlin.de>,
	"Breno Leitao" <leitao@debian.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"Shuah Khan" <shuah@kernel.org>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v3 5/5] selftests: net: add veth BQL stress test
Date: Thu, 30 Apr 2026 19:00:58 -0700	[thread overview]
Message-ID: <20260430190058.5b20b15a@kernel.org> (raw)
In-Reply-To: <20260429172036.1028526-6-hawk@kernel.org>

On Wed, 29 Apr 2026 19:20:32 +0200 hawk@kernel.org wrote:
> A companion wrapper (veth_bql_test_virtme.sh) launches the test inside
> a virtme-ng VM, with .config validation to prevent silent stalls.
> 
> Usage:
>   sudo ./veth_bql_test.sh [--duration 300] [--nrules 100]
>                           [--qdisc sfq] [--qdisc-opts '...']
>                           [--bql-disable] [--normal-napi]
>                           [--qdisc-replace]

Not convinced we need to carry this in the tree.

Honestly:

> +	close(fd);
> +	return 0;
> +}
> +CEOF
> +gcc -O2 -Wall -o "$TMPDIR"/udp_sink "$TMPDIR"/udp_sink.c -lm || exit $ksft_fail
> +}
> +
> +setup_veth() {
> +    log_info "Setting up

This whole test looks like outrageous slop.
Did you even read this? :|

  reply	other threads:[~2026-05-01  2:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29 17:20 [PATCH net-next v3 0/5] veth: add Byte Queue Limits (BQL) support hawk
2026-04-29 17:20 ` [PATCH net-next v3 1/5] net: add dev->bql flag to allow BQL sysfs for IFF_NO_QUEUE devices hawk
2026-04-29 17:20 ` [PATCH net-next v3 2/5] veth: implement Byte Queue Limits (BQL) for latency reduction hawk
2026-04-29 17:20 ` [PATCH net-next v3 3/5] veth: add tx_timeout watchdog as BQL safety net hawk
2026-04-29 17:20 ` [PATCH net-next v3 4/5] net: sched: add timeout count to NETDEV WATCHDOG message hawk
2026-04-29 17:20 ` [PATCH net-next v3 5/5] selftests: net: add veth BQL stress test hawk
2026-05-01  2:00   ` Jakub Kicinski [this message]
2026-05-01  7:03     ` Jesper Dangaard Brouer
2026-05-01  8:42   ` Breno Leitao
2026-05-01  1:58 ` [PATCH net-next v3 0/5] veth: add Byte Queue Limits (BQL) support Jakub Kicinski
2026-05-01  7:28   ` Jesper Dangaard Brouer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260430190058.5b20b15a@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=j.koeppeler@tu-berlin.de \
    --cc=kernel-team@cloudflare.com \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.