Re: [RFC PATCH v2.1 1/2] mm/damon/stat: add a parameter for reading kdamond pid

[SeongJae Park <sj@kernel.org>]

On Thu, 30 Apr 2026 15:14:18 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The newly added `kdamond_pid` module parameter lacks a `MODULE_PARM_DESC` declaration.
> --
> 
> commit d56734720ba3e7838cd85a1ac6661cf5e54d9a3b
> Author: SeongJae Park <sj@kernel.org>
> 
> mm/damon/stat: add a parameter for reading kdamond pid
> 
> Expose the pid of DAMON_STAT kdamond via a new read-only module parameter
> named kdamond_pid. This standardizes DAMON module usage, as DAMON_RECLAIM
> and DAMON_LRU_SORT also provide this information.
> 
> > diff --git a/mm/damon/stat.c b/mm/damon/stat.c
> > index f4d3203e92639..37964683839d0 100644
> > --- a/mm/damon/stat.c
> > +++ b/mm/damon/stat.c
> [ ... ]
> > +static const struct kernel_param_ops kdamond_pid_param_ops = {
> > +	.set = damon_stat_kdamond_pid_store,
> > +	.get = damon_stat_kdamond_pid_load,
> > +};
> > +
> > +/*
> > + * PID of the DAMON thread
> > + *
> > + * If DAMON_STAT is enabled, this becomes the PID of the worker thread.
> > + * Else, -1.
> > + */
> > +module_param_cb(kdamond_pid, &kdamond_pid_param_ops, NULL, 0400);
> 
> This isn't a bug, but should this module parameter include a MODULE_PARM_DESC()
> declaration?
> 
> Other parameters in mm/damon/stat.c like enabled, estimated_memory_bandwidth,
> and memory_idle_ms_percentiles have corresponding MODULE_PARM_DESC()
> declarations.

Good finding, I will add that.


Thanks,
SJ

[...]