Re: [PATCH v4 1/3] hwmon: (ads7871) Fix endianness bug in 16-bit register reads

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch includes the architecture-specific `<asm/unaligned.h>` instead of the generic `<linux/unaligned.h>`.
--

commit f2dcf018978363b0b13a49ceee94284796f154fb
Author: Tabrez Ahmed <tabreztalks@gmail.com>

hwmon: (ads7871) Fix endianness bug in 16-bit register reads

This commit replaces spi_w8r16() with a manual spi_write_then_read() into a
byte array to address an endianness bug. The 16-bit value is then safely
reconstructed using get_unaligned_le16().

Closes: https://sashiko.dev/#/patchset/20260418034601.90226-1-tabreztalks@gmail.com

> diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c
> index 9bfdf9e6bcd77..15104d9b2b733 100644
> --- a/drivers/hwmon/ads7871.c
> +++ b/drivers/hwmon/ads7871.c
> @@ -59,6 +59,7 @@
>  #include <linux/hwmon-sysfs.h>
>  #include <linux/err.h>
>  #include <linux/delay.h>
> +#include <asm/unaligned.h>

Should this use <linux/unaligned.h> instead of the architecture-specific
<asm/unaligned.h> header?

Directly including <asm/unaligned.h> can cause build failures on platforms
that no longer expose this header directly to drivers.

I notice this is addressed later in the patch series in the commit
"hwmon: (ads7871) Use DMA-safe buffer for SPI writes". Does this temporary
inclusion break the expectation that every patch in a series must
independently compile?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260501013044.22756-1-tabreztalks@gmail.com?part=1