diff for duplicates of <202605011540.0FJWFGIn-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 10337a7..2a6716b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,16 +1,6 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -CC: linux-kernel@vger.kernel.org -TO: Namjae Jeon <linkinjeon@kernel.org> -CC: Amir Goldstein <amir73il@gmail.com> -CC: Christoph Hellwig <hch@lst.de> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 26fd6bff2c050196005312d1d306889220952a99 commit: 47503f989736d6c4c9f8bfca1c28d267473ccd4b ntfs: add Kconfig and Makefile -date: 2 months ago -:::::: branch date: 7 hours ago -:::::: commit date: 2 months ago config: x86_64-randconfig-161-20260501 (https://download.01.org/0day-ci/archive/20260501/202605011540.0FJWFGIn-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 smatch: v0.5.0-9065-ge9cc34fd @@ -34,14 +24,6 @@ fs/ntfs/attrib.c:4951 ntfs_attr_remove() warn: variable dereferenced before chec vim +/ni +126 fs/ntfs/attrlist.c -495e90fa334828d Namjae Jeon 2026-02-13 104 -495e90fa334828d Namjae Jeon 2026-02-13 105 /* -495e90fa334828d Namjae Jeon 2026-02-13 106 * ntfs_attrlist_entry_add - add an attribute list attribute entry -495e90fa334828d Namjae Jeon 2026-02-13 107 * @ni: opened ntfs inode, which contains that attribute -495e90fa334828d Namjae Jeon 2026-02-13 108 * @attr: attribute record to add to attribute list -495e90fa334828d Namjae Jeon 2026-02-13 109 * -495e90fa334828d Namjae Jeon 2026-02-13 110 * Return 0 on success and -errno on error. -495e90fa334828d Namjae Jeon 2026-02-13 111 */ 495e90fa334828d Namjae Jeon 2026-02-13 112 int ntfs_attrlist_entry_add(struct ntfs_inode *ni, struct attr_record *attr) 495e90fa334828d Namjae Jeon 2026-02-13 113 { 495e90fa334828d Namjae Jeon 2026-02-13 114 struct attr_list_entry *ale; @@ -54,9 +36,13 @@ vim +/ni +126 fs/ntfs/attrlist.c 495e90fa334828d Namjae Jeon 2026-02-13 121 495e90fa334828d Namjae Jeon 2026-02-13 @122 ntfs_debug("Entering for inode 0x%llx, attr 0x%x.\n", 495e90fa334828d Namjae Jeon 2026-02-13 123 (long long) ni->mft_no, + ^^^^^^^^^^ 495e90fa334828d Namjae Jeon 2026-02-13 124 (unsigned int) le32_to_cpu(attr->type)); 495e90fa334828d Namjae Jeon 2026-02-13 125 495e90fa334828d Namjae Jeon 2026-02-13 @126 if (!ni || !attr) { + ^^^ +Checked too late. + 495e90fa334828d Namjae Jeon 2026-02-13 127 ntfs_debug("Invalid arguments.\n"); 495e90fa334828d Namjae Jeon 2026-02-13 128 return -EINVAL; 495e90fa334828d Namjae Jeon 2026-02-13 129 } @@ -71,107 +57,6 @@ vim +/ni +126 fs/ntfs/attrlist.c 495e90fa334828d Namjae Jeon 2026-02-13 138 unmap_mft_record(ni); 495e90fa334828d Namjae Jeon 2026-02-13 139 495e90fa334828d Namjae Jeon 2026-02-13 140 if (ni->nr_extents == -1) -495e90fa334828d Namjae Jeon 2026-02-13 141 ni = ni->ext.base_ntfs_ino; -495e90fa334828d Namjae Jeon 2026-02-13 142 -495e90fa334828d Namjae Jeon 2026-02-13 143 if (!NInoAttrList(ni)) { -495e90fa334828d Namjae Jeon 2026-02-13 144 ntfs_debug("Attribute list isn't present.\n"); -495e90fa334828d Namjae Jeon 2026-02-13 145 return -ENOENT; -495e90fa334828d Namjae Jeon 2026-02-13 146 } -495e90fa334828d Namjae Jeon 2026-02-13 147 -495e90fa334828d Namjae Jeon 2026-02-13 148 /* Determine size and allocate memory for new attribute list. */ -495e90fa334828d Namjae Jeon 2026-02-13 149 entry_len = (sizeof(struct attr_list_entry) + sizeof(__le16) * -495e90fa334828d Namjae Jeon 2026-02-13 150 attr->name_length + 7) & ~7; -495e90fa334828d Namjae Jeon 2026-02-13 151 new_al = kvzalloc(ni->attr_list_size + entry_len, GFP_NOFS); -495e90fa334828d Namjae Jeon 2026-02-13 152 if (!new_al) -495e90fa334828d Namjae Jeon 2026-02-13 153 return -ENOMEM; -495e90fa334828d Namjae Jeon 2026-02-13 154 -495e90fa334828d Namjae Jeon 2026-02-13 155 /* Find place for the new entry. */ -495e90fa334828d Namjae Jeon 2026-02-13 156 ctx = ntfs_attr_get_search_ctx(ni, NULL); -495e90fa334828d Namjae Jeon 2026-02-13 157 if (!ctx) { -495e90fa334828d Namjae Jeon 2026-02-13 158 err = -ENOMEM; -495e90fa334828d Namjae Jeon 2026-02-13 159 ntfs_error(ni->vol->sb, "Failed to get search context"); -495e90fa334828d Namjae Jeon 2026-02-13 160 goto err_out; -495e90fa334828d Namjae Jeon 2026-02-13 161 } -495e90fa334828d Namjae Jeon 2026-02-13 162 -495e90fa334828d Namjae Jeon 2026-02-13 163 err = ntfs_attr_lookup(attr->type, (attr->name_length) ? (__le16 *) -495e90fa334828d Namjae Jeon 2026-02-13 164 ((u8 *)attr + le16_to_cpu(attr->name_offset)) : -495e90fa334828d Namjae Jeon 2026-02-13 165 AT_UNNAMED, attr->name_length, CASE_SENSITIVE, -495e90fa334828d Namjae Jeon 2026-02-13 166 (attr->non_resident) ? le64_to_cpu(attr->data.non_resident.lowest_vcn) : -495e90fa334828d Namjae Jeon 2026-02-13 167 0, (attr->non_resident) ? NULL : ((u8 *)attr + -495e90fa334828d Namjae Jeon 2026-02-13 168 le16_to_cpu(attr->data.resident.value_offset)), (attr->non_resident) ? -495e90fa334828d Namjae Jeon 2026-02-13 169 0 : le32_to_cpu(attr->data.resident.value_length), ctx); -495e90fa334828d Namjae Jeon 2026-02-13 170 if (!err) { -495e90fa334828d Namjae Jeon 2026-02-13 171 /* Found some extent, check it to be before new extent. */ -495e90fa334828d Namjae Jeon 2026-02-13 172 if (ctx->al_entry->lowest_vcn == attr->data.non_resident.lowest_vcn) { -495e90fa334828d Namjae Jeon 2026-02-13 173 err = -EEXIST; -495e90fa334828d Namjae Jeon 2026-02-13 174 ntfs_debug("Such attribute already present in the attribute list.\n"); -495e90fa334828d Namjae Jeon 2026-02-13 175 ntfs_attr_put_search_ctx(ctx); -495e90fa334828d Namjae Jeon 2026-02-13 176 goto err_out; -495e90fa334828d Namjae Jeon 2026-02-13 177 } -495e90fa334828d Namjae Jeon 2026-02-13 178 /* Add new entry after this extent. */ -495e90fa334828d Namjae Jeon 2026-02-13 179 ale = (struct attr_list_entry *)((u8 *)ctx->al_entry + -495e90fa334828d Namjae Jeon 2026-02-13 180 le16_to_cpu(ctx->al_entry->length)); -495e90fa334828d Namjae Jeon 2026-02-13 181 } else { -495e90fa334828d Namjae Jeon 2026-02-13 182 /* Check for real errors. */ -495e90fa334828d Namjae Jeon 2026-02-13 183 if (err != -ENOENT) { -495e90fa334828d Namjae Jeon 2026-02-13 184 ntfs_debug("Attribute lookup failed.\n"); -495e90fa334828d Namjae Jeon 2026-02-13 185 ntfs_attr_put_search_ctx(ctx); -495e90fa334828d Namjae Jeon 2026-02-13 186 goto err_out; -495e90fa334828d Namjae Jeon 2026-02-13 187 } -495e90fa334828d Namjae Jeon 2026-02-13 188 /* No previous extents found. */ -495e90fa334828d Namjae Jeon 2026-02-13 189 ale = ctx->al_entry; -495e90fa334828d Namjae Jeon 2026-02-13 190 } -495e90fa334828d Namjae Jeon 2026-02-13 191 /* Don't need it anymore, @ctx->al_entry points to @ni->attr_list. */ -495e90fa334828d Namjae Jeon 2026-02-13 192 ntfs_attr_put_search_ctx(ctx); -495e90fa334828d Namjae Jeon 2026-02-13 193 -495e90fa334828d Namjae Jeon 2026-02-13 194 /* Determine new entry offset. */ -495e90fa334828d Namjae Jeon 2026-02-13 195 entry_offset = ((u8 *)ale - ni->attr_list); -495e90fa334828d Namjae Jeon 2026-02-13 196 /* Set pointer to new entry. */ -495e90fa334828d Namjae Jeon 2026-02-13 197 ale = (struct attr_list_entry *)(new_al + entry_offset); -495e90fa334828d Namjae Jeon 2026-02-13 198 memset(ale, 0, entry_len); -495e90fa334828d Namjae Jeon 2026-02-13 199 /* Form new entry. */ -495e90fa334828d Namjae Jeon 2026-02-13 200 ale->type = attr->type; -495e90fa334828d Namjae Jeon 2026-02-13 201 ale->length = cpu_to_le16(entry_len); -495e90fa334828d Namjae Jeon 2026-02-13 202 ale->name_length = attr->name_length; -495e90fa334828d Namjae Jeon 2026-02-13 203 ale->name_offset = offsetof(struct attr_list_entry, name); -495e90fa334828d Namjae Jeon 2026-02-13 204 if (attr->non_resident) -495e90fa334828d Namjae Jeon 2026-02-13 205 ale->lowest_vcn = attr->data.non_resident.lowest_vcn; -495e90fa334828d Namjae Jeon 2026-02-13 206 else -495e90fa334828d Namjae Jeon 2026-02-13 207 ale->lowest_vcn = 0; -495e90fa334828d Namjae Jeon 2026-02-13 208 ale->mft_reference = mref; -495e90fa334828d Namjae Jeon 2026-02-13 209 ale->instance = attr->instance; -495e90fa334828d Namjae Jeon 2026-02-13 210 memcpy(ale->name, (u8 *)attr + le16_to_cpu(attr->name_offset), -495e90fa334828d Namjae Jeon 2026-02-13 211 attr->name_length * sizeof(__le16)); -495e90fa334828d Namjae Jeon 2026-02-13 212 -495e90fa334828d Namjae Jeon 2026-02-13 213 /* Copy entries from old attribute list to new. */ -495e90fa334828d Namjae Jeon 2026-02-13 214 memcpy(new_al, ni->attr_list, entry_offset); -495e90fa334828d Namjae Jeon 2026-02-13 215 memcpy(new_al + entry_offset + entry_len, ni->attr_list + -495e90fa334828d Namjae Jeon 2026-02-13 216 entry_offset, ni->attr_list_size - entry_offset); -495e90fa334828d Namjae Jeon 2026-02-13 217 -495e90fa334828d Namjae Jeon 2026-02-13 218 /* Set new runlist. */ -495e90fa334828d Namjae Jeon 2026-02-13 219 old_al = ni->attr_list; -495e90fa334828d Namjae Jeon 2026-02-13 220 ni->attr_list = new_al; -495e90fa334828d Namjae Jeon 2026-02-13 221 ni->attr_list_size = ni->attr_list_size + entry_len; -495e90fa334828d Namjae Jeon 2026-02-13 222 -495e90fa334828d Namjae Jeon 2026-02-13 223 err = ntfs_attrlist_update(ni); -495e90fa334828d Namjae Jeon 2026-02-13 224 if (err) { -495e90fa334828d Namjae Jeon 2026-02-13 225 ni->attr_list = old_al; -495e90fa334828d Namjae Jeon 2026-02-13 226 ni->attr_list_size -= entry_len; -495e90fa334828d Namjae Jeon 2026-02-13 227 goto err_out; -495e90fa334828d Namjae Jeon 2026-02-13 228 } -495e90fa334828d Namjae Jeon 2026-02-13 229 kvfree(old_al); -495e90fa334828d Namjae Jeon 2026-02-13 230 return 0; -495e90fa334828d Namjae Jeon 2026-02-13 231 err_out: -495e90fa334828d Namjae Jeon 2026-02-13 232 kvfree(new_al); -495e90fa334828d Namjae Jeon 2026-02-13 233 return err; -495e90fa334828d Namjae Jeon 2026-02-13 234 } -495e90fa334828d Namjae Jeon 2026-02-13 235 - -:::::: The code at line 126 was first introduced by commit -:::::: 495e90fa334828d4119061e2726af51d0a0fb4ed ntfs: update attrib operations - -:::::: TO: Namjae Jeon <linkinjeon@kernel.org> -:::::: CC: Namjae Jeon <linkinjeon@kernel.org> -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index b049c73..206dc8c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,24 +1,18 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0fs/ntfs/attrlist.c:126 ntfs_attrlist_entry_add() warn: variable dereferenced before check 'ni' (see line 122)\0" - "Date\0Fri, 01 May 2026 15:50:20 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Fri, 1 May 2026 12:11:57 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " Namjae Jeon <linkinjeon@kernel.org>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + oe-kbuild-all@lists.linux.dev + linux-kernel@vger.kernel.org + Amir Goldstein <amir73il@gmail.com> + " Christoph Hellwig <hch@lst.de>\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "CC: linux-kernel@vger.kernel.org\n" - "TO: Namjae Jeon <linkinjeon@kernel.org>\n" - "CC: Amir Goldstein <amir73il@gmail.com>\n" - "CC: Christoph Hellwig <hch@lst.de>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master\n" "head: 26fd6bff2c050196005312d1d306889220952a99\n" "commit: 47503f989736d6c4c9f8bfca1c28d267473ccd4b ntfs: add Kconfig and Makefile\n" - "date: 2 months ago\n" - ":::::: branch date: 7 hours ago\n" - ":::::: commit date: 2 months ago\n" "config: x86_64-randconfig-161-20260501 (https://download.01.org/0day-ci/archive/20260501/202605011540.0FJWFGIn-lkp@intel.com/config)\n" "compiler: gcc-14 (Debian 14.2.0-19) 14.2.0\n" "smatch: v0.5.0-9065-ge9cc34fd\n" @@ -42,14 +36,6 @@ "\n" "vim +/ni +126 fs/ntfs/attrlist.c\n" "\n" - "495e90fa334828d Namjae Jeon 2026-02-13 104 \n" - "495e90fa334828d Namjae Jeon 2026-02-13 105 /*\n" - "495e90fa334828d Namjae Jeon 2026-02-13 106 * ntfs_attrlist_entry_add - add an attribute list attribute entry\n" - "495e90fa334828d Namjae Jeon 2026-02-13 107 * @ni:\topened ntfs inode, which contains that attribute\n" - "495e90fa334828d Namjae Jeon 2026-02-13 108 * @attr: attribute record to add to attribute list\n" - "495e90fa334828d Namjae Jeon 2026-02-13 109 *\n" - "495e90fa334828d Namjae Jeon 2026-02-13 110 * Return 0 on success and -errno on error.\n" - "495e90fa334828d Namjae Jeon 2026-02-13 111 */\n" "495e90fa334828d Namjae Jeon 2026-02-13 112 int ntfs_attrlist_entry_add(struct ntfs_inode *ni, struct attr_record *attr)\n" "495e90fa334828d Namjae Jeon 2026-02-13 113 {\n" "495e90fa334828d Namjae Jeon 2026-02-13 114 \tstruct attr_list_entry *ale;\n" @@ -62,9 +48,13 @@ "495e90fa334828d Namjae Jeon 2026-02-13 121 \n" "495e90fa334828d Namjae Jeon 2026-02-13 @122 \tntfs_debug(\"Entering for inode 0x%llx, attr 0x%x.\\n\",\n" "495e90fa334828d Namjae Jeon 2026-02-13 123 \t\t\t(long long) ni->mft_no,\n" + " ^^^^^^^^^^\n" "495e90fa334828d Namjae Jeon 2026-02-13 124 \t\t\t(unsigned int) le32_to_cpu(attr->type));\n" "495e90fa334828d Namjae Jeon 2026-02-13 125 \n" "495e90fa334828d Namjae Jeon 2026-02-13 @126 \tif (!ni || !attr) {\n" + " ^^^\n" + "Checked too late.\n" + "\n" "495e90fa334828d Namjae Jeon 2026-02-13 127 \t\tntfs_debug(\"Invalid arguments.\\n\");\n" "495e90fa334828d Namjae Jeon 2026-02-13 128 \t\treturn -EINVAL;\n" "495e90fa334828d Namjae Jeon 2026-02-13 129 \t}\n" @@ -79,110 +69,9 @@ "495e90fa334828d Namjae Jeon 2026-02-13 138 \tunmap_mft_record(ni);\n" "495e90fa334828d Namjae Jeon 2026-02-13 139 \n" "495e90fa334828d Namjae Jeon 2026-02-13 140 \tif (ni->nr_extents == -1)\n" - "495e90fa334828d Namjae Jeon 2026-02-13 141 \t\tni = ni->ext.base_ntfs_ino;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 142 \n" - "495e90fa334828d Namjae Jeon 2026-02-13 143 \tif (!NInoAttrList(ni)) {\n" - "495e90fa334828d Namjae Jeon 2026-02-13 144 \t\tntfs_debug(\"Attribute list isn't present.\\n\");\n" - "495e90fa334828d Namjae Jeon 2026-02-13 145 \t\treturn -ENOENT;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 146 \t}\n" - "495e90fa334828d Namjae Jeon 2026-02-13 147 \n" - "495e90fa334828d Namjae Jeon 2026-02-13 148 \t/* Determine size and allocate memory for new attribute list. */\n" - "495e90fa334828d Namjae Jeon 2026-02-13 149 \tentry_len = (sizeof(struct attr_list_entry) + sizeof(__le16) *\n" - "495e90fa334828d Namjae Jeon 2026-02-13 150 \t\t\tattr->name_length + 7) & ~7;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 151 \tnew_al = kvzalloc(ni->attr_list_size + entry_len, GFP_NOFS);\n" - "495e90fa334828d Namjae Jeon 2026-02-13 152 \tif (!new_al)\n" - "495e90fa334828d Namjae Jeon 2026-02-13 153 \t\treturn -ENOMEM;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 154 \n" - "495e90fa334828d Namjae Jeon 2026-02-13 155 \t/* Find place for the new entry. */\n" - "495e90fa334828d Namjae Jeon 2026-02-13 156 \tctx = ntfs_attr_get_search_ctx(ni, NULL);\n" - "495e90fa334828d Namjae Jeon 2026-02-13 157 \tif (!ctx) {\n" - "495e90fa334828d Namjae Jeon 2026-02-13 158 \t\terr = -ENOMEM;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 159 \t\tntfs_error(ni->vol->sb, \"Failed to get search context\");\n" - "495e90fa334828d Namjae Jeon 2026-02-13 160 \t\tgoto err_out;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 161 \t}\n" - "495e90fa334828d Namjae Jeon 2026-02-13 162 \n" - "495e90fa334828d Namjae Jeon 2026-02-13 163 \terr = ntfs_attr_lookup(attr->type, (attr->name_length) ? (__le16 *)\n" - "495e90fa334828d Namjae Jeon 2026-02-13 164 \t\t\t((u8 *)attr + le16_to_cpu(attr->name_offset)) :\n" - "495e90fa334828d Namjae Jeon 2026-02-13 165 \t\t\tAT_UNNAMED, attr->name_length, CASE_SENSITIVE,\n" - "495e90fa334828d Namjae Jeon 2026-02-13 166 \t\t\t(attr->non_resident) ? le64_to_cpu(attr->data.non_resident.lowest_vcn) :\n" - "495e90fa334828d Namjae Jeon 2026-02-13 167 \t\t\t0, (attr->non_resident) ? NULL : ((u8 *)attr +\n" - "495e90fa334828d Namjae Jeon 2026-02-13 168 \t\t\tle16_to_cpu(attr->data.resident.value_offset)), (attr->non_resident) ?\n" - "495e90fa334828d Namjae Jeon 2026-02-13 169 \t\t\t0 : le32_to_cpu(attr->data.resident.value_length), ctx);\n" - "495e90fa334828d Namjae Jeon 2026-02-13 170 \tif (!err) {\n" - "495e90fa334828d Namjae Jeon 2026-02-13 171 \t\t/* Found some extent, check it to be before new extent. */\n" - "495e90fa334828d Namjae Jeon 2026-02-13 172 \t\tif (ctx->al_entry->lowest_vcn == attr->data.non_resident.lowest_vcn) {\n" - "495e90fa334828d Namjae Jeon 2026-02-13 173 \t\t\terr = -EEXIST;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 174 \t\t\tntfs_debug(\"Such attribute already present in the attribute list.\\n\");\n" - "495e90fa334828d Namjae Jeon 2026-02-13 175 \t\t\tntfs_attr_put_search_ctx(ctx);\n" - "495e90fa334828d Namjae Jeon 2026-02-13 176 \t\t\tgoto err_out;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 177 \t\t}\n" - "495e90fa334828d Namjae Jeon 2026-02-13 178 \t\t/* Add new entry after this extent. */\n" - "495e90fa334828d Namjae Jeon 2026-02-13 179 \t\tale = (struct attr_list_entry *)((u8 *)ctx->al_entry +\n" - "495e90fa334828d Namjae Jeon 2026-02-13 180 \t\t\t\tle16_to_cpu(ctx->al_entry->length));\n" - "495e90fa334828d Namjae Jeon 2026-02-13 181 \t} else {\n" - "495e90fa334828d Namjae Jeon 2026-02-13 182 \t\t/* Check for real errors. */\n" - "495e90fa334828d Namjae Jeon 2026-02-13 183 \t\tif (err != -ENOENT) {\n" - "495e90fa334828d Namjae Jeon 2026-02-13 184 \t\t\tntfs_debug(\"Attribute lookup failed.\\n\");\n" - "495e90fa334828d Namjae Jeon 2026-02-13 185 \t\t\tntfs_attr_put_search_ctx(ctx);\n" - "495e90fa334828d Namjae Jeon 2026-02-13 186 \t\t\tgoto err_out;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 187 \t\t}\n" - "495e90fa334828d Namjae Jeon 2026-02-13 188 \t\t/* No previous extents found. */\n" - "495e90fa334828d Namjae Jeon 2026-02-13 189 \t\tale = ctx->al_entry;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 190 \t}\n" - "495e90fa334828d Namjae Jeon 2026-02-13 191 \t/* Don't need it anymore, @ctx->al_entry points to @ni->attr_list. */\n" - "495e90fa334828d Namjae Jeon 2026-02-13 192 \tntfs_attr_put_search_ctx(ctx);\n" - "495e90fa334828d Namjae Jeon 2026-02-13 193 \n" - "495e90fa334828d Namjae Jeon 2026-02-13 194 \t/* Determine new entry offset. */\n" - "495e90fa334828d Namjae Jeon 2026-02-13 195 \tentry_offset = ((u8 *)ale - ni->attr_list);\n" - "495e90fa334828d Namjae Jeon 2026-02-13 196 \t/* Set pointer to new entry. */\n" - "495e90fa334828d Namjae Jeon 2026-02-13 197 \tale = (struct attr_list_entry *)(new_al + entry_offset);\n" - "495e90fa334828d Namjae Jeon 2026-02-13 198 \tmemset(ale, 0, entry_len);\n" - "495e90fa334828d Namjae Jeon 2026-02-13 199 \t/* Form new entry. */\n" - "495e90fa334828d Namjae Jeon 2026-02-13 200 \tale->type = attr->type;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 201 \tale->length = cpu_to_le16(entry_len);\n" - "495e90fa334828d Namjae Jeon 2026-02-13 202 \tale->name_length = attr->name_length;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 203 \tale->name_offset = offsetof(struct attr_list_entry, name);\n" - "495e90fa334828d Namjae Jeon 2026-02-13 204 \tif (attr->non_resident)\n" - "495e90fa334828d Namjae Jeon 2026-02-13 205 \t\tale->lowest_vcn = attr->data.non_resident.lowest_vcn;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 206 \telse\n" - "495e90fa334828d Namjae Jeon 2026-02-13 207 \t\tale->lowest_vcn = 0;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 208 \tale->mft_reference = mref;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 209 \tale->instance = attr->instance;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 210 \tmemcpy(ale->name, (u8 *)attr + le16_to_cpu(attr->name_offset),\n" - "495e90fa334828d Namjae Jeon 2026-02-13 211 \t\t\tattr->name_length * sizeof(__le16));\n" - "495e90fa334828d Namjae Jeon 2026-02-13 212 \n" - "495e90fa334828d Namjae Jeon 2026-02-13 213 \t/* Copy entries from old attribute list to new. */\n" - "495e90fa334828d Namjae Jeon 2026-02-13 214 \tmemcpy(new_al, ni->attr_list, entry_offset);\n" - "495e90fa334828d Namjae Jeon 2026-02-13 215 \tmemcpy(new_al + entry_offset + entry_len, ni->attr_list +\n" - "495e90fa334828d Namjae Jeon 2026-02-13 216 \t\t\tentry_offset, ni->attr_list_size - entry_offset);\n" - "495e90fa334828d Namjae Jeon 2026-02-13 217 \n" - "495e90fa334828d Namjae Jeon 2026-02-13 218 \t/* Set new runlist. */\n" - "495e90fa334828d Namjae Jeon 2026-02-13 219 \told_al = ni->attr_list;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 220 \tni->attr_list = new_al;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 221 \tni->attr_list_size = ni->attr_list_size + entry_len;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 222 \n" - "495e90fa334828d Namjae Jeon 2026-02-13 223 \terr = ntfs_attrlist_update(ni);\n" - "495e90fa334828d Namjae Jeon 2026-02-13 224 \tif (err) {\n" - "495e90fa334828d Namjae Jeon 2026-02-13 225 \t\tni->attr_list = old_al;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 226 \t\tni->attr_list_size -= entry_len;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 227 \t\tgoto err_out;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 228 \t}\n" - "495e90fa334828d Namjae Jeon 2026-02-13 229 \tkvfree(old_al);\n" - "495e90fa334828d Namjae Jeon 2026-02-13 230 \treturn 0;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 231 err_out:\n" - "495e90fa334828d Namjae Jeon 2026-02-13 232 \tkvfree(new_al);\n" - "495e90fa334828d Namjae Jeon 2026-02-13 233 \treturn err;\n" - "495e90fa334828d Namjae Jeon 2026-02-13 234 }\n" - "495e90fa334828d Namjae Jeon 2026-02-13 235 \n" - "\n" - ":::::: The code at line 126 was first introduced by commit\n" - ":::::: 495e90fa334828d4119061e2726af51d0a0fb4ed ntfs: update attrib operations\n" - "\n" - ":::::: TO: Namjae Jeon <linkinjeon@kernel.org>\n" - ":::::: CC: Namjae Jeon <linkinjeon@kernel.org>\n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -2be3cd0123b9df9b7000fe54144b69553e48b15bfbfbf858381e0cb05d759541 +e6fa6fd8536cd89f46ef85ed9d01f5dc82532c9a149564b733f2d0a7ec9f045e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.