All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	Ian Rogers <irogers@google.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v19 0/7] ring-buffer: Making persistent ring buffers robust
Date: Sat, 2 May 2026 15:23:04 -0400	[thread overview]
Message-ID: <20260502152304.560a5954@robin> (raw)
In-Reply-To: <177751968499.2136606.17388366710182662849.stgit@mhiramat.tok.corp.google.com>

[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

Hi Masami,

I applied your patches and enabled your ptracingtest code. I noticed
that when there's dropped pages, the trace output is not in order:

 # trace-cmd start -B ptracingtest -e all -v -e '*lock*'
 # taskset -c 5 echo c > /proc/sysrq-trigger

On reboot, I ran:

 # trace-cmd show -B ptracingtest > /tmp/trace.out

Then executed the attached perl program:

  # ./read-ts.pl < /tmp/trace.out

And it errors our:

 30.212495 < 30.213534
           <...>-1048    [005] d....    30.212495: irq_enable: caller=irqentry_exit+0xf5/0x710 parent=0x0

That is, I think the zero timestamps may be messing with the order.

-- Steve

[-- Attachment #2: read-ts.pl --]
[-- Type: application/x-perl, Size: 300 bytes --]

  parent reply	other threads:[~2026-05-02 19:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30  3:28 [PATCH v19 0/7] ring-buffer: Making persistent ring buffers robust Masami Hiramatsu (Google)
2026-04-30  3:28 ` [PATCH v19 1/7] ring-buffer: Flush and stop persistent ring buffer on panic Masami Hiramatsu (Google)
2026-04-30  3:28 ` [PATCH v19 2/7] ring-buffer: Skip invalid sub-buffers when validating persistent ring buffer Masami Hiramatsu (Google)
2026-04-30  3:28 ` [PATCH v19 3/7] ring-buffer: Skip invalid sub-buffers when rewinding " Masami Hiramatsu (Google)
2026-04-30  3:28 ` [PATCH v19 4/7] ring-buffer: Add persistent ring buffer invalid-page inject test Masami Hiramatsu (Google)
2026-04-30  3:28 ` [PATCH v19 5/7] ring-buffer: Show commit numbers in buffer_meta file Masami Hiramatsu (Google)
2026-04-30  3:28 ` [PATCH v19 6/7] ring-buffer: Cleanup persistent ring buffer validation Masami Hiramatsu (Google)
2026-04-30  3:29 ` [PATCH v19 7/7] ring-buffer: Cleanup buffer_data_page related code Masami Hiramatsu (Google)
2026-05-02 19:23 ` Steven Rostedt [this message]
2026-05-02 22:17   ` [PATCH v19 0/7] ring-buffer: Making persistent ring buffers robust Steven Rostedt
2026-05-07  4:14     ` Masami Hiramatsu
2026-05-11 16:29       ` Steven Rostedt
2026-05-12  0:54         ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260502152304.560a5954@robin \
    --to=rostedt@goodmis.org \
    --cc=catalin.marinas@arm.com \
    --cc=irogers@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.