All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Andy Shevchenko" <andriy.shevchenko@intel.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	linux-pci@vger.kernel.org,
	"Xunlei Pang" <xlpang@linux.alibaba.com>,
	oliver.yang@linux.alibaba.com
Subject: Re: [PATCH v11 1/2] PCI: Introduce named defines for PCI ROM
Date: Sun, 3 May 2026 01:55:26 +0900	[thread overview]
Message-ID: <20260502165133.GB1323630@rocinante> (raw)
In-Reply-To: <20260130080729.96152-2-kanie@linux.alibaba.com>

Hello,

> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>  		/* Standard PCI ROMs start out with these bytes 55 AA */

Just a small nitpick: would it make sense to move this comment above to
where the definition is now?  Like the one for "PCIR" signature.

>  		/* get the PCI data structure and check its "PCIR" signature */

I realise this has been here before, but it would be nice to capitalise
this "get" in the comment above.  However, this is also a tiny nitpick,
so feel free to ignore.

But otherwise:

  Reviewed-by: Krzysztof Wilczyński <kwilczynski@kernel.org>

Thank you!

	Krzysztof

  reply	other threads:[~2026-05-02 16:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-30  8:07 [PATCH v11 0/2] PCI: Fix crash when access broken ROM Guixin Liu
2026-01-30  8:07 ` [PATCH v11 1/2] PCI: Introduce named defines for PCI ROM Guixin Liu
2026-05-02 16:55   ` Krzysztof Wilczyński [this message]
2026-05-06  4:40     ` Guixin Liu
2026-01-30  8:07 ` [PATCH v11 2/2] PCI: Check ROM header and data structure addr before accessing Guixin Liu
2026-04-30 21:46   ` Bjorn Helgaas
2026-05-06  4:39     ` Guixin Liu
2026-02-09  6:43 ` [PATCH v11 0/2] PCI: Fix crash when access broken ROM Guixin Liu
2026-02-09 17:54   ` Bjorn Helgaas
2026-04-24  6:32     ` Guixin Liu
2026-04-24  8:38       ` Andy Shevchenko
2026-04-30  2:01       ` Guixin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260502165133.GB1323630@rocinante \
    --to=kw@linux.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=bhelgaas@google.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=kanie@linux.alibaba.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=oliver.yang@linux.alibaba.com \
    --cc=xlpang@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.