Re: [PATCH 2/2] hwmon: (lm75) Support active-high alert polarity

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]

On Fri, May 01, 2026 at 12:32:47PM -0700, Guenter Roeck wrote:
> On 5/1/26 10:05, Conor Dooley wrote:
> > On Fri, May 01, 2026 at 02:05:18PM +0200, Markus Stockhausen wrote:
> > > All chips supported by this driver support configurable active-high
> > > alert polarity. This is already documented in the devicetree description.
> > > Add support for it to the driver.
> > > 
> > > The default polarity of the devices is 0 (active-low). So there is
> > > no need to change the clear mask. For consistency reasons adapt the
> > > hard-coded configuration value of the AS6200. It is the only device
> > > that defaults to active-high polarity.
> > 
> > Uh, I dunno if you can do this, changing defaults is an ABI break
> > typically. What makes it okay to do that in this case?
> > 
> 
> Turns out the driver doesn't actually set the polarity bit due to a driver
> bug, and no one noticed. Also, _if_ active high polarity is set, the _alarm
> attribute shows the wrong value due to a second bug in the driver.
> Given all that, there is no real ABI breakage.

Cool :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]