From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: Ziming Du <duziming2@huawei.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, liuyongqiang13@huawei.com
Subject: Re: [PATCH 4/4] PCI: Prevent overflow in proc_bus_pci_read()
Date: Mon, 4 May 2026 07:38:11 +0900 [thread overview]
Message-ID: <20260503222916.GA3862479@rocinante> (raw)
In-Reply-To: <20260414024544.2975605-5-duziming2@huawei.com>
Hello,
> diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c
> index a5db7d23353a..f11f48becf52 100644
> --- a/drivers/pci/proc.c
> +++ b/drivers/pci/proc.c
> @@ -29,7 +29,7 @@ static ssize_t proc_bus_pci_read(struct file *file, char __user *buf,
> size_t nbytes, loff_t *ppos)
> {
> struct pci_dev *dev = pde_data(file_inode(file));
> - unsigned int off = *ppos;
> + loff_t off = *ppos;
> unsigned int count = nbytes;
> unsigned int size;
You could merge this patch with the previews one. This will close the gap
on the signed/unsigned promotion issue that Sashiko is complaining about.
Thank you!
Krzysztof
next prev parent reply other threads:[~2026-05-03 22:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 2:45 [PATCH 0/4] PCI: Fix procfs PCI config access issues Ziming Du
2026-04-14 2:45 ` [PATCH 1/4] PCI: Align proc_bus_pci_write() with pci_write_config() Ziming Du
2026-05-03 23:02 ` Krzysztof Wilczyński
2026-04-14 2:45 ` [PATCH 2/4] PCI: Align proc_bus_pci_read() with pci_read_config() Ziming Du
2026-04-14 2:45 ` [PATCH 3/4] PCI: Prevent overflow in proc_bus_pci_write() Ziming Du
2026-04-14 2:45 ` [PATCH 4/4] PCI: Prevent overflow in proc_bus_pci_read() Ziming Du
2026-05-03 22:38 ` Krzysztof Wilczyński [this message]
2026-04-27 2:22 ` [PING] PCI: Fix procfs PCI config access issues duziming
2026-04-27 22:19 ` [PATCH 0/4] " Bjorn Helgaas
2026-07-28 23:19 ` Krzysztof Wilczyński
2026-07-29 1:53 ` duziming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260503222916.GA3862479@rocinante \
--to=kwilczynski@kernel.org \
--cc=bhelgaas@google.com \
--cc=duziming2@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liuyongqiang13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.