From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, David Heidelberg <david@ixit.cz>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Subject: Re: [PATCH 1/1] media: v4l2-subdev: Fail {enable,disable}_streams and s_streaming nicely
Date: Mon, 4 May 2026 16:22:14 +0300 [thread overview]
Message-ID: <20260504132214.GA1371451@killaraus.ideasonboard.com> (raw)
In-Reply-To: <20260504123503.417044-1-sakari.ailus@linux.intel.com>
On Mon, May 04, 2026 at 03:35:03PM +0300, Sakari Ailus wrote:
> If a sub-device does not set enable_streams() and disable_streams() pad
> ops while it sets the s_stream() video op to
> v4l2_subdev_s_stream_helper(), enabling or disabling streaming either way
> on the sub-device will result calling v4l2_subdev_s_stream_helper() and
> v4l2_subdev_{enable,disable}_streams() recursively, exhausting the stack.
> Return -ENOIOCTLCMD in this case to handle the situation gracefully.
>
> Reported-by: David Heidelberg <david@ixit.cz>
> Fixes: b62949ddaa52 ("media: subdev: Support single-stream case in v4l2_subdev_enable/disable_streams()")
> Cc: stable@vger.kernel.org
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> since v2:
>
> - Move the check, with checking the pad ops, to
> v4l2_subdev_s_stream_helper().
>
> drivers/media/v4l2-core/v4l2-subdev.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
> index 831c69c958b8..3b726f044d3f 100644
> --- a/drivers/media/v4l2-core/v4l2-subdev.c
> +++ b/drivers/media/v4l2-core/v4l2-subdev.c
> @@ -2504,6 +2504,10 @@ int v4l2_subdev_s_stream_helper(struct v4l2_subdev *sd, int enable)
> u64 source_mask = 0;
> int pad_index = -1;
>
> + if (WARN_ON_ONCE(!v4l2_subdev_has_op(sd, pad, enable_streams) ||
> + !v4l2_subdev_has_op(sd, pad, disable_streams)))
Is this indicates a clear bug, I would use WARN_ON() instead of
WARN_ON_ONCE(). Up to you.
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> + return -ENOIOCTLCMD;
> +
> /*
> * Find the source pad. This helper is meant for subdevs that have a
> * single source pad, so failures shouldn't happen, but catch them
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2026-05-04 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 12:35 [PATCH 1/1] media: v4l2-subdev: Fail {enable,disable}_streams and s_streaming nicely Sakari Ailus
2026-05-04 12:37 ` Sakari Ailus
2026-05-04 13:22 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504132214.GA1371451@killaraus.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=david@ixit.cz \
--cc=hverkuil+cisco@kernel.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen+renesas@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.