From: Jakov Novak <jakovnovak30@gmail.com>
To: johannes@sipsolutions.net
Cc: dcbw@redhat.com, jakovnovak30@gmail.com, kees@kernel.org,
libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, linville@tuxdriver.com,
mingo@kernel.org, skhan@linuxfoundation.org,
swilczek.lx@gmail.com,
syzbot+c99d17aa44dbdba16ad2@syzkaller.appspotmail.com,
tglx@kernel.org
Subject: [resend PATCH v2 1/1] wifi: libertas: add wake_up() call to properly notify
Date: Mon, 4 May 2026 17:04:16 +0200 [thread overview]
Message-ID: <20260504150416.4853-2-jakovnovak30@gmail.com> (raw)
In-Reply-To: <20260504150416.4853-1-jakovnovak30@gmail.com>
This is necessary because the thread would be stuck if the
firmware is not fully loaded before the if_usb_disconnect function is
called. In that case if_usb_prog_firmware would be stuck in
wait_event_interruptible and lbs_remove_card would also be stuck waiting
for firmware loading to be done which was the original bug reported.
Fixes: 954ee164f4f4 ("[PATCH] libertas: reorganize and simplify init sequence")
Reported-and-tested-by: syzbot+c99d17aa44dbdba16ad2@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=c99d17aa44dbdba16ad2
Signed-off-by: Jakov Novak <jakovnovak30@gmail.com>
---
drivers/net/wireless/marvell/libertas/if_usb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/marvell/libertas/if_usb.c b/drivers/net/wireless/marvell/libertas/if_usb.c
index 4fae0e335136..22f0bd6a141a 100644
--- a/drivers/net/wireless/marvell/libertas/if_usb.c
+++ b/drivers/net/wireless/marvell/libertas/if_usb.c
@@ -310,6 +310,7 @@ static void if_usb_disconnect(struct usb_interface *intf)
struct lbs_private *priv = cardp->priv;
cardp->surprise_removed = 1;
+ wake_up(&cardp->fw_wq);
if (priv) {
lbs_stop_card(priv);
--
2.54.0
next prev parent reply other threads:[~2026-05-04 15:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 21:32 [PATCH 0/1] usb: fix bug in marvell libertas driver Jakov Novak
2026-04-10 21:32 ` [PATCH 1/1] add wake_up call inside if_usb_disconnect Jakov Novak
2026-04-15 12:11 ` Johannes Berg
2026-04-15 13:31 ` [PATCH v2 0/1] wifi: libertas: fix bug in Marvell Libertas driver Jakov Novak
2026-04-15 13:31 ` [PATCH v2 1/1] wifi: libertas: add wake_up() call to properly notify fw_wq during disconnect Jakov Novak
2026-05-04 15:04 ` [resend PATCH v2 0/1] wifi: libertas: fix bug in Marvell Libertas driver Jakov Novak
2026-05-04 15:04 ` Jakov Novak [this message]
2026-05-04 15:11 ` Johannes Berg
2026-05-04 15:59 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504150416.4853-2-jakovnovak30@gmail.com \
--to=jakovnovak30@gmail.com \
--cc=dcbw@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=kees@kernel.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mingo@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=swilczek.lx@gmail.com \
--cc=syzbot+c99d17aa44dbdba16ad2@syzkaller.appspotmail.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.