All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Tom Herbert <tom@herbertland.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	justin.iurman@uliege.be, willemdebruijn.kernel@gmail.com,
	pabeni@redhat.com, horms@kernel.org, Tom Herbert <tom@xdpnet.ai>
Subject: Re: [PATCH net-next v10 00/10] ipv6: Address ext hdr DoS vulnerabilities
Date: Mon, 4 May 2026 16:44:48 -0700	[thread overview]
Message-ID: <20260504164448.0ba4a2df@kernel.org> (raw)
In-Reply-To: <20260504185122.50642-1-tom@xdpnet.ai>

On Mon,  4 May 2026 11:51:12 -0700 Tom Herbert wrote:
> --- Testing
> 
> Add selftest eh_limits.sh. Tested by running:
> 
> $ sudo ./eh_limits.sh
>     TEST: EH-limits - default sysctls                            [ OK ]
>     TEST: EH-limits - modified sysctls                           [ OK ]
> 
> Tests passed:   2
> Tests failed:   0


The python files need to be in TEST_FILES not TEST_PROGS
(AFAIU they are helpers not tests themselves).
They must pass ruff check and pylint --disable=R cleanly

The bash currently passes but prints a FAIL making our CI mark it as
FAIL:

# selftests: net: eh_limits.sh
# 2.50 [+2.50] WARNING: Could not retrieve the OS's nameserver !
# 4.54 [+2.04] WARNING: Could not retrieve the OS's nameserver !
# 6.29 [+1.74]     TEST: EH-limits - default sysctls                                   [ OK ]
# 6.54 [+0.25] WARNING: Could not retrieve the OS's nameserver !
# 7.90 [+1.36] FAIL: Expected to receive for Many EH OOO                  <<<< here <<<
# 8.00 [+0.10]     TEST: EH-limits - modified sysctls                                  [ OK ]
# 8.02 [+0.02] 
# 8.02 [+0.00] Tests passed:   2
# 8.02 [+0.00] Tests failed:   0

Definitely does not look like your results..
Note that we run the tests with

	make -C tools/testing/selftests run_tests TEST_PROGS="eh_limits.sh" TEST_GEN_PROGS=""

  parent reply	other threads:[~2026-05-04 23:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 18:51 [PATCH net-next v10 00/10] ipv6: Address ext hdr DoS vulnerabilities Tom Herbert
2026-05-04 18:51 ` [PATCH net-next v10 01/10] ipv6: Check of max HBH or DestOp sysctl is zero and drop if it is Tom Herbert
2026-05-04 18:51 ` [PATCH net-next v10 02/10] ipv6: Cleanup IPv6 TLV definitions Tom Herbert
2026-05-04 18:51 ` [PATCH net-next v10 03/10] ipv6: Add case for IPV6_TLV_TNL_ENCAP_LIMIT in EH TLV switch Tom Herbert
2026-05-04 18:51 ` [PATCH net-next v10 04/10] ipv6: Set HBH and DestOpt limits to 2 Tom Herbert
2026-05-04 18:51 ` [PATCH net-next v10 05/10] ipv6: Document defaults for max_{dst|hbh}_opts_number sysctls Tom Herbert
2026-05-04 18:51 ` [PATCH net-next v10 06/10] ipv6: Enforce Extension Header ordering Tom Herbert
2026-05-04 18:51 ` [PATCH net-next v10 07/10] ipv6: Document enforce_ext_hdr_order sysctl Tom Herbert
2026-05-04 18:51 ` [PATCH net-next v10 08/10] test: Add proto_nums.py in networking selftests Tom Herbert
2026-05-04 18:51 ` [PATCH net-next v10 09/10] test: Add ext_hdr.py " Tom Herbert
2026-05-04 18:51 ` [PATCH net-next v10 10/10] test: Add networking selftest for eh limits Tom Herbert
2026-05-04 23:44 ` Jakub Kicinski [this message]
2026-05-05 17:11 ` [PATCH net-next v10 00/10] ipv6: Address ext hdr DoS vulnerabilities Justin Iurman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260504164448.0ba4a2df@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=horms@kernel.org \
    --cc=justin.iurman@uliege.be \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tom@herbertland.com \
    --cc=tom@xdpnet.ai \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.