Re: [PATCH v2 2/2] iio: light: veml6030: Generalize hw_init for veml6030 and veml6035

[Jonathan Cameron <jic23@kernel.org>]

On Mon, 4 May 2026 17:14:56 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Sat, May 02, 2026 at 08:41:04PM -0300, Gabriel Braga Lagrotaria wrote:
> > Modify veml6030_hw_init() function to deduplicate the setup logic
> > for veml6030_hw_init() and veml6035_hw_init(), and remove
> > veml6035_hw_init().
> > 
> > Additionally, introduce struct veml6030_hw_init_config_desc to store and
> > pass the custom configuration values specific to each device variation.  
> 
> ...
> 
> > @@ -963,61 +972,21 @@ static int veml6030_regfield_init(struct iio_dev *indio_dev)
> >  	return 0;
> >  }
> >  
> > +  
> 
> I can argue that this is a stray change, but I'm not objecting to having it.

I am. Don't see a reason for two blank lines here.
There are subsystems where that is standard formatting, but it's not in IIO
and this driver doesn't do double blank lines anywhere else.

I guess Garbriel has been looking at other drivers where that style may
be in use.