All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Linus Probert <linus.probert@gmail.com>
Cc: Luka Gejak <luka.gejak@linux.dev>,
	Dan Carpenter <error27@gmail.com>,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH 0/8] staging: rtl8723bs: remove warnings in rtw_btcoex.h
Date: Mon, 4 May 2026 16:22:27 +0200	[thread overview]
Message-ID: <2026050421-wrench-driver-de6d@gregkh> (raw)
In-Reply-To: <177746706634.1273374.11369919005007087628.b4-reply@b4>

On Wed, Apr 29, 2026 at 02:51:06PM +0200, Linus Probert wrote:
> On 2026-04-29 14:18:55+02:00, Luka Gejak wrote:
> > On April 29, 2026 2:06:30 PM GMT+02:00, Dan Carpenter <error27@gmail.com> wrote:
> > 
> > >On Wed, Apr 29, 2026 at 01:34:41PM +0200, Luka Gejak wrote:
> > >
> > >Greg has said in the past he prefers them all as separate changes the
> > >way this patchset does it.  He recently asked somone to split up a
> > >typedef patch into one typedef per patch.
> > >
> > >regards,
> > >dan carpenter
> > 
> > Thanks for that information Dan, I wasn't awear of that.
> > Best regards,
> > Luka Gejak
> 
> Thanks, then I did understand your suggestion correctly. Just wasn't
> sure. As Dan stated I've learnt that Greg prefers one commit per function
> for these cases.

Yes, this is great, thanks!

greg k-h

      reply	other threads:[~2026-05-04 14:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 17:38 [PATCH 0/8] staging: rtl8723bs: remove warnings in rtw_btcoex.h Linus Probert
2026-04-27 17:38 ` [PATCH 1/8] staging: rtl8723bs: remove blank line " Linus Probert
2026-04-27 17:38 ` [PATCH 2/8] staging: rtl8723bs: add function definition arg names to rtw_btcoex.h Linus Probert
2026-04-27 17:38 ` [PATCH 3/8] staging: rtl8723bs: rename rtw_btcoex_MediaStatusNotify() Linus Probert
2026-04-27 17:38 ` [PATCH 4/8] staging: rtl8723bs: rename rtw_btcoex_media_status_notify definition arg Linus Probert
2026-04-27 17:38 ` [PATCH 5/8] staging: rtl8723bs: rtw_btcoex_HaltNotify() -> rtw_btcoex_halt_notify() Linus Probert
2026-04-27 17:38 ` [PATCH 6/8] staging: rtl8723bs: rename rtw_btcoex_RejectApAggregatedPacket() Linus Probert
2026-04-27 17:38 ` [PATCH 7/8] staging: rtl8723bs: rtw_btcoex_LPS_Enter() -> rtw_btcoex_lps_enter() Linus Probert
2026-04-27 17:38 ` [PATCH 8/8] staging: rtl8723bs: rename rtw_btcoex_LPS_Leave to rtw_btcoex_lps_leave Linus Probert
2026-04-29 10:18 ` [PATCH 0/8] staging: rtl8723bs: remove warnings in rtw_btcoex.h Luka Gejak
2026-04-29 10:24   ` Luka Gejak
2026-04-29 10:46     ` Linus Probert
2026-04-29 11:34       ` Luka Gejak
2026-04-29 12:06         ` Dan Carpenter
2026-04-29 12:18           ` Luka Gejak
2026-04-29 12:51             ` Linus Probert
2026-05-04 14:22               ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026050421-wrench-driver-de6d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=error27@gmail.com \
    --cc=linus.probert@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=luka.gejak@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.