All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ayush Mukkanwar <ayushmukkanwar@gmail.com>
Cc: error27@gmail.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/4] staging: octeon: replace pr_warn with dev_warn in fill path
Date: Mon, 4 May 2026 16:21:06 +0200	[thread overview]
Message-ID: <2026050441-vessel-goldmine-2bb6@gregkh> (raw)
In-Reply-To: <20260427151556.91153-3-ayushmukkanwar@gmail.com>

On Mon, Apr 27, 2026 at 08:45:53PM +0530, Ayush Mukkanwar wrote:
> Replace pr_warn() with dev_warn() in cvm_oct_fill_hw_memory() to
> include device information in log messages.
> 
> To make the device pointer accessible from the workqueue callback,
> introduce struct octeon_ethernet_platform to hold both a struct
> device pointer and the delayed_work. This replaces the static global
> cvm_oct_rx_refill_work. The struct is allocated with devm_kzalloc()
> in probe() and stored via platform_set_drvdata(). The worker
> retrieves it using container_of().
> 
> Add a struct device pointer to oct_rx_group and thread it through
> cvm_oct_rx_initialize() to support the NAPI poll refill path.

Why isn't this the platform device?  And why isn't this data just part
of the platform device's data anyway?  Why is it a separate "thing"?

thanks,

greg k-h

  reply	other threads:[~2026-05-04 14:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 15:15 [PATCH v5 0/4] staging: octeon: modernize logging and refactor to per-device state Ayush Mukkanwar
2026-04-27 15:15 ` [PATCH v5 1/4] staging: octeon: ethernet-mem: replace pr_warn with dev_warn in free functions Ayush Mukkanwar
2026-05-04 14:20   ` Greg KH
2026-04-27 15:15 ` [PATCH v5 2/4] staging: octeon: replace pr_warn with dev_warn in fill path Ayush Mukkanwar
2026-05-04 14:21   ` Greg KH [this message]
2026-05-04 17:04     ` Ayush Mukkanwar
2026-04-27 15:15 ` [PATCH v5 3/4] staging: octeon: ethernet: replace pr_err and pr_info with dev_err and netdev_err Ayush Mukkanwar
2026-04-27 15:15 ` [PATCH v5 4/4] staging: octeon: refactor to per-device state and pass platform_device Ayush Mukkanwar
2026-04-28  9:48   ` Dan Carpenter
2026-04-28 14:31     ` Ayush Mukkanwar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026050441-vessel-goldmine-2bb6@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ayushmukkanwar@gmail.com \
    --cc=error27@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.