All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: alexanderduyck@fb.com, virtio-comment@lists.linux.dev
Subject: virtio balloon poison feature
Date: Tue, 5 May 2026 11:41:20 -0400	[thread overview]
Message-ID: <20260505102918-mutt-send-email-mst@kernel.org> (raw)

Hi Alexander, all.
I am looking at this old commit and I am confused:


commit 4749f03e72f8ff6e66f54e38e41a560014e1a0e3
Author: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Date:   Tue Aug 25 07:45:10 2020 -0700

    content: Document balloon feature page poison
    
    Page poison provides a way for the guest to notify the host that it is
    initializing or poisoning freed pages with some specific poison value. As a
    result of this we can infer a couple traits about the guest:
    
    1. Free pages will contain a specific pattern within the guest.
    2. Modifying free pages from this value may cause an error in the guest.
    3. Pages will be immediately written to by the driver when deflated.
    
    There are currently no existing features that make use of this data. In the
    upcoming feature free page reporting we will need to make use of this to
    identify if we can evict pages from the guest without causing data
    corruption.
    
    Add documentation for the page poison feature describing the basic
    functionality and requirements.
    
    Fixes: https://github.com/oasis-tcs/virtio-spec/issues/84
    Reviewed-by: Cornelia Huck <cohuck@redhat.com>
    Reviewed-by: David Hildenbrand <david@redhat.com>
    Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
    Signed-off-by: Cornelia Huck <cohuck@redhat.com>



here is what I do not understand: why does driver tell device that
it will poison the pages after deflate? device does not access them
anymore so why does it care? should this have been *before inflate*,
actually?

how was this envisioned to be used?


Thanks,
-- 
MST


                 reply	other threads:[~2026-05-05 15:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260505102918-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=alexanderduyck@fb.com \
    --cc=virtio-comment@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.