From: Lee Jones <lee@kernel.org>
To: "Escala, Edelweise" <Edelweise.Escala@analog.com>
Cc: Pavel Machek <pavel@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 2/2] leds: ltc3220: Add Support for LTC3220 18 channel LED Driver
Date: Tue, 5 May 2026 16:02:17 +0100 [thread overview]
Message-ID: <20260505150217.GD2661693@google.com> (raw)
In-Reply-To: <DS0PR03MB7228ACA655995A9CAC025B35ED312@DS0PR03MB7228.namprd03.prod.outlook.com>
On Mon, 04 May 2026, Escala, Edelweise wrote:
> Hello Lee,
>
> Thank you for the review.
>
> > > +static const struct regmap_config ltc3220_regmap_config = {
> > > + .reg_bits = 8,
> > > + .val_bits = 8,
> > > + .max_register = LTC3220_GRAD_BLINK_REG, };
> >
> > .cache_type?
> >
>
> I will add
> .cache_type = REGCACHE_FLAT,
No need to reply to review comments that you agree with.
--
Lee Jones
prev parent reply other threads:[~2026-05-05 15:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 9:42 [PATCH v6 0/2] Add Support for LTC3220 18 Channel LED Driver Edelweise Escala
2026-04-17 9:42 ` [PATCH v6 1/2] dt-bindings: leds: Add LTC3220 18 channel " Edelweise Escala
2026-04-17 9:42 ` [PATCH v6 2/2] leds: ltc3220: Add Support for " Edelweise Escala
2026-04-30 17:11 ` Lee Jones
2026-05-04 1:31 ` Escala, Edelweise
2026-05-05 15:02 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260505150217.GD2661693@google.com \
--to=lee@kernel.org \
--cc=Edelweise.Escala@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.