From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC9EDFF8855 for ; Tue, 5 May 2026 16:26:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 119F110E428; Tue, 5 May 2026 16:26:33 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="P3c57A43"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC13310E428; Tue, 5 May 2026 16:26:31 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5EC0740403; Tue, 5 May 2026 16:26:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D7D5C2BCB4; Tue, 5 May 2026 16:26:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777998391; bh=d9oRhAaRGwydDiDuK7BhCRvRWDp8pOBlU9+d0qcoLXY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=P3c57A43Ly9U95oakv1tzSfsBDMAQvbGX3L5fDur0PPxN8g/BkGWOrF0IQ1vnb8kn q5FpFULXXt5CFm8Sy/qdB+pGfZ+595OPQ/+H2h/dpiAmaAvc14vlTx4Z7a774smhAG mRi8mWrUgi+n3TQ7klBwMiCHYz3eCKtTXeoo5Vugwd9W8wFUQWC/qxp4tUJmAVvLgS jHSgvFYD9WkXPVvCXJZvfwe/RjozMVbFHi4OoCu3mLeSQZDLHCSt79QQSlDeG2UmtL GPSyoqLckepvJjFkRnrQa3yfyKh+iIz18B0bEQzeLYkJERNnopW8hE0+mQWVZV5SLC bwYA1sJR8mQqw== Date: Tue, 5 May 2026 11:26:29 -0500 From: Bjorn Helgaas To: Vladimir Oltean Cc: linux-phy@lists.infradead.org, Vinod Koul , Neil Armstrong , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, spacemit@lists.linux.dev, UNGLinuxDriver@microchip.com, Bjorn Helgaas , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Lorenzo Pieralisi , Manikandan K Pillai , Manivannan Sadhasivam , Rob Herring , Tom Joseph Subject: Re: [PATCH v8 phy-next 01/31] PCI: cadence: Preserve all error codes in cdns_plat_pcie_probe() Message-ID: <20260505162629.GA734488@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260505100523.1922388-2-vladimir.oltean@nxp.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" [+cc Tom, author of bd22885aa188 in case there's something subtle here] On Tue, May 05, 2026 at 01:04:53PM +0300, Vladimir Oltean wrote: > The blamed commit functionally changed the error path of > cdns_pcie_host_probe(), now cdns_plat_pcie_probe(). > > When the old code path executed "goto err_get_sync", the PCIe controller > probe function propagated the pm_runtime_get_sync() error code. The new > code doesn't, and returns 0. > > Similarly for the "goto err_init" previously triggered by > cdns_pcie_host_init() errors, and now triggered by > cdns_pcie_host_setup() and cdns_pcie_ep_setup() errors. These are not > propagated and will result in probing success, which is incorrect. > > Fixes: bd22885aa188 ("PCI: cadence: Refactor driver to use as a core library") > Signed-off-by: Vladimir Oltean > --- > Cc: Bjorn Helgaas > Cc: "Krzysztof Wilczyński" > Cc: Lorenzo Pieralisi > Cc: Manikandan K Pillai > Cc: Manivannan Sadhasivam > Cc: Rob Herring I guess this driver is orphaned. Acked-by: Bjorn Helgaas > v7->v8: patch is new, issue was flagged by Sashiko > https://sashiko.dev/#/patchset/20260430110652.558622-1-vladimir.oltean@nxp.com > --- > drivers/pci/controller/cadence/pcie-cadence-plat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/cadence/pcie-cadence-plat.c b/drivers/pci/controller/cadence/pcie-cadence-plat.c > index b067a3296dd3..8b12a46b5601 100644 > --- a/drivers/pci/controller/cadence/pcie-cadence-plat.c > +++ b/drivers/pci/controller/cadence/pcie-cadence-plat.c > @@ -126,7 +126,7 @@ static int cdns_plat_pcie_probe(struct platform_device *pdev) > while (phy_count--) > device_link_del(cdns_plat_pcie->pcie->link[phy_count]); > > - return 0; > + return ret; This affects cases where pm_runtime_get_sync(), cdns_pcie_host_setup(), or cdns_pcie_ep_setup() return failure. Seems right to me to fail the probe when these fail. Not all users of pm_runtime_get_sync() check for failure, but I think all the other controller drivers that do check return failures from the .probe(). > } > > static void cdns_plat_pcie_shutdown(struct platform_device *pdev) > -- > 2.34.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F730CD3439 for ; Tue, 5 May 2026 16:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=7BeN6thporY+jKUrGV1okd1u3POVYBA7JSKtUYf0MV0=; b=iHSRoXBwyYUe6f xYDa5uk0rTlFdF1o+bKmM1PmeyrXr8AO/snYvDrfHvpKxMgk9hCTnOX0JxEW8TgADVOyBR7adz7OG MClJ8UUtNo9axVG9BSp2kTofBAPj/NaYosJ3CwmcIh3B8Mnly5WeymVz1ngIrv90O/D3OZpszAfuY oPC8eucWWubMYAXzkFRLYHFe3V9IuDwjrK3NM5GQgwvi2+sKMV0vIoOfAU9Cv4vFkfiG8IBk34KHU A86dHKxoFxcGnKusbDQRt/dxs/8unf+ATJJSlowWgvPAMjEGmlCuU88p+MDPqkSyURSRZxZUj6wMa Jq249p/yILq63VBaRJTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wKIbS-0000000GsYm-3LYq; Tue, 05 May 2026 16:26:34 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wKIbQ-0000000GsX8-0sVc; Tue, 05 May 2026 16:26:33 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5EC0740403; Tue, 5 May 2026 16:26:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D7D5C2BCB4; Tue, 5 May 2026 16:26:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777998391; bh=d9oRhAaRGwydDiDuK7BhCRvRWDp8pOBlU9+d0qcoLXY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=P3c57A43Ly9U95oakv1tzSfsBDMAQvbGX3L5fDur0PPxN8g/BkGWOrF0IQ1vnb8kn q5FpFULXXt5CFm8Sy/qdB+pGfZ+595OPQ/+H2h/dpiAmaAvc14vlTx4Z7a774smhAG mRi8mWrUgi+n3TQ7klBwMiCHYz3eCKtTXeoo5Vugwd9W8wFUQWC/qxp4tUJmAVvLgS jHSgvFYD9WkXPVvCXJZvfwe/RjozMVbFHi4OoCu3mLeSQZDLHCSt79QQSlDeG2UmtL GPSyoqLckepvJjFkRnrQa3yfyKh+iIz18B0bEQzeLYkJERNnopW8hE0+mQWVZV5SLC bwYA1sJR8mQqw== Date: Tue, 5 May 2026 11:26:29 -0500 From: Bjorn Helgaas To: Vladimir Oltean Cc: linux-phy@lists.infradead.org, Vinod Koul , Neil Armstrong , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, spacemit@lists.linux.dev, UNGLinuxDriver@microchip.com, Bjorn Helgaas , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Lorenzo Pieralisi , Manikandan K Pillai , Manivannan Sadhasivam , Rob Herring , Tom Joseph Subject: Re: [PATCH v8 phy-next 01/31] PCI: cadence: Preserve all error codes in cdns_plat_pcie_probe() Message-ID: <20260505162629.GA734488@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260505100523.1922388-2-vladimir.oltean@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260505_092632_286618_5A5FAA07 X-CRM114-Status: GOOD ( 21.06 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org WytjYyBUb20sIGF1dGhvciBvZiBiZDIyODg1YWExODggaW4gY2FzZSB0aGVyZSdzIHNvbWV0aGlu ZyBzdWJ0bGUgaGVyZV0KCk9uIFR1ZSwgTWF5IDA1LCAyMDI2IGF0IDAxOjA0OjUzUE0gKzAzMDAs IFZsYWRpbWlyIE9sdGVhbiB3cm90ZToKPiBUaGUgYmxhbWVkIGNvbW1pdCBmdW5jdGlvbmFsbHkg Y2hhbmdlZCB0aGUgZXJyb3IgcGF0aCBvZgo+IGNkbnNfcGNpZV9ob3N0X3Byb2JlKCksIG5vdyBj ZG5zX3BsYXRfcGNpZV9wcm9iZSgpLgo+IAo+IFdoZW4gdGhlIG9sZCBjb2RlIHBhdGggZXhlY3V0 ZWQgImdvdG8gZXJyX2dldF9zeW5jIiwgdGhlIFBDSWUgY29udHJvbGxlcgo+IHByb2JlIGZ1bmN0 aW9uIHByb3BhZ2F0ZWQgdGhlIHBtX3J1bnRpbWVfZ2V0X3N5bmMoKSBlcnJvciBjb2RlLiBUaGUg bmV3Cj4gY29kZSBkb2Vzbid0LCBhbmQgcmV0dXJucyAwLgo+IAo+IFNpbWlsYXJseSBmb3IgdGhl ICJnb3RvIGVycl9pbml0IiBwcmV2aW91c2x5IHRyaWdnZXJlZCBieQo+IGNkbnNfcGNpZV9ob3N0 X2luaXQoKSBlcnJvcnMsIGFuZCBub3cgdHJpZ2dlcmVkIGJ5Cj4gY2Ruc19wY2llX2hvc3Rfc2V0 dXAoKSBhbmQgY2Ruc19wY2llX2VwX3NldHVwKCkgZXJyb3JzLiBUaGVzZSBhcmUgbm90Cj4gcHJv cGFnYXRlZCBhbmQgd2lsbCByZXN1bHQgaW4gcHJvYmluZyBzdWNjZXNzLCB3aGljaCBpcyBpbmNv cnJlY3QuCj4gCj4gRml4ZXM6IGJkMjI4ODVhYTE4OCAoIlBDSTogY2FkZW5jZTogUmVmYWN0b3Ig ZHJpdmVyIHRvIHVzZSBhcyBhIGNvcmUgbGlicmFyeSIpCj4gU2lnbmVkLW9mZi1ieTogVmxhZGlt aXIgT2x0ZWFuIDx2bGFkaW1pci5vbHRlYW5AbnhwLmNvbT4KPiAtLS0KPiBDYzogQmpvcm4gSGVs Z2FhcyA8YmhlbGdhYXNAZ29vZ2xlLmNvbT4KPiBDYzogIktyenlzenRvZiBXaWxjennFhHNraSIg PGt3aWxjenluc2tpQGtlcm5lbC5vcmc+Cj4gQ2M6IExvcmVuem8gUGllcmFsaXNpIDxscGllcmFs aXNpQGtlcm5lbC5vcmc+Cj4gQ2M6IE1hbmlrYW5kYW4gSyBQaWxsYWkgPG1waWxsYWlAY2FkZW5j ZS5jb20+Cj4gQ2M6IE1hbml2YW5uYW4gU2FkaGFzaXZhbSA8bWFuaUBrZXJuZWwub3JnPgo+IENj OiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPgoKSSBndWVzcyB0aGlzIGRyaXZlciBpcyBv cnBoYW5lZC4KCkFja2VkLWJ5OiBCam9ybiBIZWxnYWFzIDxiaGVsZ2Fhc0Bnb29nbGUuY29tPgoK PiB2Ny0+djg6IHBhdGNoIGlzIG5ldywgaXNzdWUgd2FzIGZsYWdnZWQgYnkgU2FzaGlrbwo+IGh0 dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDQzMDExMDY1Mi41NTg2MjItMS12bGFk aW1pci5vbHRlYW5AbnhwLmNvbQo+IC0tLQo+ICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2NhZGVu Y2UvcGNpZS1jYWRlbmNlLXBsYXQuYyB8IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRy b2xsZXIvY2FkZW5jZS9wY2llLWNhZGVuY2UtcGxhdC5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxl ci9jYWRlbmNlL3BjaWUtY2FkZW5jZS1wbGF0LmMKPiBpbmRleCBiMDY3YTMyOTZkZDMuLjhiMTJh NDZiNTYwMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2NhZGVuY2UvcGNp ZS1jYWRlbmNlLXBsYXQuYwo+ICsrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvY2FkZW5jZS9w Y2llLWNhZGVuY2UtcGxhdC5jCj4gQEAgLTEyNiw3ICsxMjYsNyBAQCBzdGF0aWMgaW50IGNkbnNf cGxhdF9wY2llX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAl3aGlsZSAo cGh5X2NvdW50LS0pCj4gIAkJZGV2aWNlX2xpbmtfZGVsKGNkbnNfcGxhdF9wY2llLT5wY2llLT5s aW5rW3BoeV9jb3VudF0pOwo+ICAKPiAtCXJldHVybiAwOwo+ICsJcmV0dXJuIHJldDsKClRoaXMg YWZmZWN0cyBjYXNlcyB3aGVyZSBwbV9ydW50aW1lX2dldF9zeW5jKCksCmNkbnNfcGNpZV9ob3N0 X3NldHVwKCksIG9yIGNkbnNfcGNpZV9lcF9zZXR1cCgpIHJldHVybiBmYWlsdXJlLgoKU2VlbXMg cmlnaHQgdG8gbWUgdG8gZmFpbCB0aGUgcHJvYmUgd2hlbiB0aGVzZSBmYWlsLgoKTm90IGFsbCB1 c2VycyBvZiBwbV9ydW50aW1lX2dldF9zeW5jKCkgY2hlY2sgZm9yIGZhaWx1cmUsIGJ1dCBJIHRo aW5rCmFsbCB0aGUgb3RoZXIgY29udHJvbGxlciBkcml2ZXJzIHRoYXQgZG8gY2hlY2sgcmV0dXJu IGZhaWx1cmVzIGZyb20KdGhlIC5wcm9iZSgpLgoKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgY2Ru c19wbGF0X3BjaWVfc2h1dGRvd24oc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAtLSAK PiAyLjM0LjEKPiAKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32EB3CD3427 for ; Tue, 5 May 2026 16:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=3DDYlcWDvjjn4p1Y1nocnGa+l/H/8ix0h5v6JeXPE4k=; b=h9qYhDxRQAF3+z UThAsFu9HwBwh1XpZVNZaxGW0QSrgdDTvsCJs4Lkw9+a3aEmtwGnWIiq7GXkxCZIMkdqglBuJIwAO Mgii+BrR4D8ZvmWuI4GUAI7NGTjGEtY4MvH/GKPpVM69XzgJ2eNQKW/nmvDJbUmYCVH1R6FxxAhbs b/3Hz8bAbfRsmB2+CFQ+30u8Sv/v/pudiHvjTlbUich1rcOyCdGfUKpSgklOwUGFMGj0qCat0V3VA J+G2LNiWuLP5o3dcNqp0G7zRhTCuQyGzSnwm7xgCaFAw12phJrsCFsJ+x6rUBKdmUXwUCLk7g/gKj jEoNOkmMUMiTXL1xAnZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wKIbT-0000000GsYy-0DPx; Tue, 05 May 2026 16:26:35 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wKIbQ-0000000GsX8-0sVc; Tue, 05 May 2026 16:26:33 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5EC0740403; Tue, 5 May 2026 16:26:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D7D5C2BCB4; Tue, 5 May 2026 16:26:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777998391; bh=d9oRhAaRGwydDiDuK7BhCRvRWDp8pOBlU9+d0qcoLXY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=P3c57A43Ly9U95oakv1tzSfsBDMAQvbGX3L5fDur0PPxN8g/BkGWOrF0IQ1vnb8kn q5FpFULXXt5CFm8Sy/qdB+pGfZ+595OPQ/+H2h/dpiAmaAvc14vlTx4Z7a774smhAG mRi8mWrUgi+n3TQ7klBwMiCHYz3eCKtTXeoo5Vugwd9W8wFUQWC/qxp4tUJmAVvLgS jHSgvFYD9WkXPVvCXJZvfwe/RjozMVbFHi4OoCu3mLeSQZDLHCSt79QQSlDeG2UmtL GPSyoqLckepvJjFkRnrQa3yfyKh+iIz18B0bEQzeLYkJERNnopW8hE0+mQWVZV5SLC bwYA1sJR8mQqw== Date: Tue, 5 May 2026 11:26:29 -0500 From: Bjorn Helgaas To: Vladimir Oltean Cc: linux-phy@lists.infradead.org, Vinod Koul , Neil Armstrong , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, spacemit@lists.linux.dev, UNGLinuxDriver@microchip.com, Bjorn Helgaas , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Lorenzo Pieralisi , Manikandan K Pillai , Manivannan Sadhasivam , Rob Herring , Tom Joseph Subject: Re: [PATCH v8 phy-next 01/31] PCI: cadence: Preserve all error codes in cdns_plat_pcie_probe() Message-ID: <20260505162629.GA734488@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260505100523.1922388-2-vladimir.oltean@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260505_092632_286618_5A5FAA07 X-CRM114-Status: GOOD ( 21.06 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org WytjYyBUb20sIGF1dGhvciBvZiBiZDIyODg1YWExODggaW4gY2FzZSB0aGVyZSdzIHNvbWV0aGlu ZyBzdWJ0bGUgaGVyZV0KCk9uIFR1ZSwgTWF5IDA1LCAyMDI2IGF0IDAxOjA0OjUzUE0gKzAzMDAs IFZsYWRpbWlyIE9sdGVhbiB3cm90ZToKPiBUaGUgYmxhbWVkIGNvbW1pdCBmdW5jdGlvbmFsbHkg Y2hhbmdlZCB0aGUgZXJyb3IgcGF0aCBvZgo+IGNkbnNfcGNpZV9ob3N0X3Byb2JlKCksIG5vdyBj ZG5zX3BsYXRfcGNpZV9wcm9iZSgpLgo+IAo+IFdoZW4gdGhlIG9sZCBjb2RlIHBhdGggZXhlY3V0 ZWQgImdvdG8gZXJyX2dldF9zeW5jIiwgdGhlIFBDSWUgY29udHJvbGxlcgo+IHByb2JlIGZ1bmN0 aW9uIHByb3BhZ2F0ZWQgdGhlIHBtX3J1bnRpbWVfZ2V0X3N5bmMoKSBlcnJvciBjb2RlLiBUaGUg bmV3Cj4gY29kZSBkb2Vzbid0LCBhbmQgcmV0dXJucyAwLgo+IAo+IFNpbWlsYXJseSBmb3IgdGhl ICJnb3RvIGVycl9pbml0IiBwcmV2aW91c2x5IHRyaWdnZXJlZCBieQo+IGNkbnNfcGNpZV9ob3N0 X2luaXQoKSBlcnJvcnMsIGFuZCBub3cgdHJpZ2dlcmVkIGJ5Cj4gY2Ruc19wY2llX2hvc3Rfc2V0 dXAoKSBhbmQgY2Ruc19wY2llX2VwX3NldHVwKCkgZXJyb3JzLiBUaGVzZSBhcmUgbm90Cj4gcHJv cGFnYXRlZCBhbmQgd2lsbCByZXN1bHQgaW4gcHJvYmluZyBzdWNjZXNzLCB3aGljaCBpcyBpbmNv cnJlY3QuCj4gCj4gRml4ZXM6IGJkMjI4ODVhYTE4OCAoIlBDSTogY2FkZW5jZTogUmVmYWN0b3Ig ZHJpdmVyIHRvIHVzZSBhcyBhIGNvcmUgbGlicmFyeSIpCj4gU2lnbmVkLW9mZi1ieTogVmxhZGlt aXIgT2x0ZWFuIDx2bGFkaW1pci5vbHRlYW5AbnhwLmNvbT4KPiAtLS0KPiBDYzogQmpvcm4gSGVs Z2FhcyA8YmhlbGdhYXNAZ29vZ2xlLmNvbT4KPiBDYzogIktyenlzenRvZiBXaWxjennFhHNraSIg PGt3aWxjenluc2tpQGtlcm5lbC5vcmc+Cj4gQ2M6IExvcmVuem8gUGllcmFsaXNpIDxscGllcmFs aXNpQGtlcm5lbC5vcmc+Cj4gQ2M6IE1hbmlrYW5kYW4gSyBQaWxsYWkgPG1waWxsYWlAY2FkZW5j ZS5jb20+Cj4gQ2M6IE1hbml2YW5uYW4gU2FkaGFzaXZhbSA8bWFuaUBrZXJuZWwub3JnPgo+IENj OiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPgoKSSBndWVzcyB0aGlzIGRyaXZlciBpcyBv cnBoYW5lZC4KCkFja2VkLWJ5OiBCam9ybiBIZWxnYWFzIDxiaGVsZ2Fhc0Bnb29nbGUuY29tPgoK PiB2Ny0+djg6IHBhdGNoIGlzIG5ldywgaXNzdWUgd2FzIGZsYWdnZWQgYnkgU2FzaGlrbwo+IGh0 dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDQzMDExMDY1Mi41NTg2MjItMS12bGFk aW1pci5vbHRlYW5AbnhwLmNvbQo+IC0tLQo+ICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2NhZGVu Y2UvcGNpZS1jYWRlbmNlLXBsYXQuYyB8IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRy b2xsZXIvY2FkZW5jZS9wY2llLWNhZGVuY2UtcGxhdC5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxl ci9jYWRlbmNlL3BjaWUtY2FkZW5jZS1wbGF0LmMKPiBpbmRleCBiMDY3YTMyOTZkZDMuLjhiMTJh NDZiNTYwMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2NhZGVuY2UvcGNp ZS1jYWRlbmNlLXBsYXQuYwo+ICsrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvY2FkZW5jZS9w Y2llLWNhZGVuY2UtcGxhdC5jCj4gQEAgLTEyNiw3ICsxMjYsNyBAQCBzdGF0aWMgaW50IGNkbnNf cGxhdF9wY2llX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAl3aGlsZSAo cGh5X2NvdW50LS0pCj4gIAkJZGV2aWNlX2xpbmtfZGVsKGNkbnNfcGxhdF9wY2llLT5wY2llLT5s aW5rW3BoeV9jb3VudF0pOwo+ICAKPiAtCXJldHVybiAwOwo+ICsJcmV0dXJuIHJldDsKClRoaXMg YWZmZWN0cyBjYXNlcyB3aGVyZSBwbV9ydW50aW1lX2dldF9zeW5jKCksCmNkbnNfcGNpZV9ob3N0 X3NldHVwKCksIG9yIGNkbnNfcGNpZV9lcF9zZXR1cCgpIHJldHVybiBmYWlsdXJlLgoKU2VlbXMg cmlnaHQgdG8gbWUgdG8gZmFpbCB0aGUgcHJvYmUgd2hlbiB0aGVzZSBmYWlsLgoKTm90IGFsbCB1 c2VycyBvZiBwbV9ydW50aW1lX2dldF9zeW5jKCkgY2hlY2sgZm9yIGZhaWx1cmUsIGJ1dCBJIHRo aW5rCmFsbCB0aGUgb3RoZXIgY29udHJvbGxlciBkcml2ZXJzIHRoYXQgZG8gY2hlY2sgcmV0dXJu IGZhaWx1cmVzIGZyb20KdGhlIC5wcm9iZSgpLgoKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgY2Ru c19wbGF0X3BjaWVfc2h1dGRvd24oc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAtLSAK PiAyLjM0LjEKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlz Y3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61A4AFF8855 for ; Tue, 5 May 2026 16:26:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=eIye/26QM4AWi3QaSGqhP0AFAntuAZk8OLelh68Ztiw=; b=xRbQ3S4UEH1s84 a3TbcDH3bI0X31hjI6jXR9Me6vZBmNPNN9MQqqwQrXm/+uH371H7HbfEyYACVUPNO2wWAhF7T4Oa6 TVCYiaIzqFNM+XJA3VO0ZprhZW6Qk5V7g/AK1+xurZ8dS5zv42eLr+lPTMS8wvvr0n5wDFm5Y9gkv Rv/08StmI/+hD7FPZ/hUTpLFmJaxxesuPBL7CLdHEj4Wx7MbVTcmFE+0rpYCONMNFF1+U3D17S9NL dnkZPjEzU0YPPblA/sntjF1AcrenoRoPa2qpr/FhPrPFg/77hGbTx5bm4AlgDXvNoeaC2uuSvHpHn 2mtXJg8e+FUM2Va2oFfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wKIbT-0000000GsZ4-1SM3; Tue, 05 May 2026 16:26:35 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wKIbQ-0000000GsX8-0sVc; Tue, 05 May 2026 16:26:33 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5EC0740403; Tue, 5 May 2026 16:26:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D7D5C2BCB4; Tue, 5 May 2026 16:26:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777998391; bh=d9oRhAaRGwydDiDuK7BhCRvRWDp8pOBlU9+d0qcoLXY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=P3c57A43Ly9U95oakv1tzSfsBDMAQvbGX3L5fDur0PPxN8g/BkGWOrF0IQ1vnb8kn q5FpFULXXt5CFm8Sy/qdB+pGfZ+595OPQ/+H2h/dpiAmaAvc14vlTx4Z7a774smhAG mRi8mWrUgi+n3TQ7klBwMiCHYz3eCKtTXeoo5Vugwd9W8wFUQWC/qxp4tUJmAVvLgS jHSgvFYD9WkXPVvCXJZvfwe/RjozMVbFHi4OoCu3mLeSQZDLHCSt79QQSlDeG2UmtL GPSyoqLckepvJjFkRnrQa3yfyKh+iIz18B0bEQzeLYkJERNnopW8hE0+mQWVZV5SLC bwYA1sJR8mQqw== Date: Tue, 5 May 2026 11:26:29 -0500 From: Bjorn Helgaas To: Vladimir Oltean Cc: linux-phy@lists.infradead.org, Vinod Koul , Neil Armstrong , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, spacemit@lists.linux.dev, UNGLinuxDriver@microchip.com, Bjorn Helgaas , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Lorenzo Pieralisi , Manikandan K Pillai , Manivannan Sadhasivam , Rob Herring , Tom Joseph Subject: Re: [PATCH v8 phy-next 01/31] PCI: cadence: Preserve all error codes in cdns_plat_pcie_probe() Message-ID: <20260505162629.GA734488@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260505100523.1922388-2-vladimir.oltean@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260505_092632_286618_5A5FAA07 X-CRM114-Status: GOOD ( 21.06 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org WytjYyBUb20sIGF1dGhvciBvZiBiZDIyODg1YWExODggaW4gY2FzZSB0aGVyZSdzIHNvbWV0aGlu ZyBzdWJ0bGUgaGVyZV0KCk9uIFR1ZSwgTWF5IDA1LCAyMDI2IGF0IDAxOjA0OjUzUE0gKzAzMDAs IFZsYWRpbWlyIE9sdGVhbiB3cm90ZToKPiBUaGUgYmxhbWVkIGNvbW1pdCBmdW5jdGlvbmFsbHkg Y2hhbmdlZCB0aGUgZXJyb3IgcGF0aCBvZgo+IGNkbnNfcGNpZV9ob3N0X3Byb2JlKCksIG5vdyBj ZG5zX3BsYXRfcGNpZV9wcm9iZSgpLgo+IAo+IFdoZW4gdGhlIG9sZCBjb2RlIHBhdGggZXhlY3V0 ZWQgImdvdG8gZXJyX2dldF9zeW5jIiwgdGhlIFBDSWUgY29udHJvbGxlcgo+IHByb2JlIGZ1bmN0 aW9uIHByb3BhZ2F0ZWQgdGhlIHBtX3J1bnRpbWVfZ2V0X3N5bmMoKSBlcnJvciBjb2RlLiBUaGUg bmV3Cj4gY29kZSBkb2Vzbid0LCBhbmQgcmV0dXJucyAwLgo+IAo+IFNpbWlsYXJseSBmb3IgdGhl ICJnb3RvIGVycl9pbml0IiBwcmV2aW91c2x5IHRyaWdnZXJlZCBieQo+IGNkbnNfcGNpZV9ob3N0 X2luaXQoKSBlcnJvcnMsIGFuZCBub3cgdHJpZ2dlcmVkIGJ5Cj4gY2Ruc19wY2llX2hvc3Rfc2V0 dXAoKSBhbmQgY2Ruc19wY2llX2VwX3NldHVwKCkgZXJyb3JzLiBUaGVzZSBhcmUgbm90Cj4gcHJv cGFnYXRlZCBhbmQgd2lsbCByZXN1bHQgaW4gcHJvYmluZyBzdWNjZXNzLCB3aGljaCBpcyBpbmNv cnJlY3QuCj4gCj4gRml4ZXM6IGJkMjI4ODVhYTE4OCAoIlBDSTogY2FkZW5jZTogUmVmYWN0b3Ig ZHJpdmVyIHRvIHVzZSBhcyBhIGNvcmUgbGlicmFyeSIpCj4gU2lnbmVkLW9mZi1ieTogVmxhZGlt aXIgT2x0ZWFuIDx2bGFkaW1pci5vbHRlYW5AbnhwLmNvbT4KPiAtLS0KPiBDYzogQmpvcm4gSGVs Z2FhcyA8YmhlbGdhYXNAZ29vZ2xlLmNvbT4KPiBDYzogIktyenlzenRvZiBXaWxjennFhHNraSIg PGt3aWxjenluc2tpQGtlcm5lbC5vcmc+Cj4gQ2M6IExvcmVuem8gUGllcmFsaXNpIDxscGllcmFs aXNpQGtlcm5lbC5vcmc+Cj4gQ2M6IE1hbmlrYW5kYW4gSyBQaWxsYWkgPG1waWxsYWlAY2FkZW5j ZS5jb20+Cj4gQ2M6IE1hbml2YW5uYW4gU2FkaGFzaXZhbSA8bWFuaUBrZXJuZWwub3JnPgo+IENj OiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPgoKSSBndWVzcyB0aGlzIGRyaXZlciBpcyBv cnBoYW5lZC4KCkFja2VkLWJ5OiBCam9ybiBIZWxnYWFzIDxiaGVsZ2Fhc0Bnb29nbGUuY29tPgoK PiB2Ny0+djg6IHBhdGNoIGlzIG5ldywgaXNzdWUgd2FzIGZsYWdnZWQgYnkgU2FzaGlrbwo+IGh0 dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDQzMDExMDY1Mi41NTg2MjItMS12bGFk aW1pci5vbHRlYW5AbnhwLmNvbQo+IC0tLQo+ICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2NhZGVu Y2UvcGNpZS1jYWRlbmNlLXBsYXQuYyB8IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRy b2xsZXIvY2FkZW5jZS9wY2llLWNhZGVuY2UtcGxhdC5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxl ci9jYWRlbmNlL3BjaWUtY2FkZW5jZS1wbGF0LmMKPiBpbmRleCBiMDY3YTMyOTZkZDMuLjhiMTJh NDZiNTYwMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2NhZGVuY2UvcGNp ZS1jYWRlbmNlLXBsYXQuYwo+ICsrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvY2FkZW5jZS9w Y2llLWNhZGVuY2UtcGxhdC5jCj4gQEAgLTEyNiw3ICsxMjYsNyBAQCBzdGF0aWMgaW50IGNkbnNf cGxhdF9wY2llX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAl3aGlsZSAo cGh5X2NvdW50LS0pCj4gIAkJZGV2aWNlX2xpbmtfZGVsKGNkbnNfcGxhdF9wY2llLT5wY2llLT5s aW5rW3BoeV9jb3VudF0pOwo+ICAKPiAtCXJldHVybiAwOwo+ICsJcmV0dXJuIHJldDsKClRoaXMg YWZmZWN0cyBjYXNlcyB3aGVyZSBwbV9ydW50aW1lX2dldF9zeW5jKCksCmNkbnNfcGNpZV9ob3N0 X3NldHVwKCksIG9yIGNkbnNfcGNpZV9lcF9zZXR1cCgpIHJldHVybiBmYWlsdXJlLgoKU2VlbXMg cmlnaHQgdG8gbWUgdG8gZmFpbCB0aGUgcHJvYmUgd2hlbiB0aGVzZSBmYWlsLgoKTm90IGFsbCB1 c2VycyBvZiBwbV9ydW50aW1lX2dldF9zeW5jKCkgY2hlY2sgZm9yIGZhaWx1cmUsIGJ1dCBJIHRo aW5rCmFsbCB0aGUgb3RoZXIgY29udHJvbGxlciBkcml2ZXJzIHRoYXQgZG8gY2hlY2sgcmV0dXJu IGZhaWx1cmVzIGZyb20KdGhlIC5wcm9iZSgpLgoKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgY2Ru c19wbGF0X3BjaWVfc2h1dGRvd24oc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAtLSAK PiAyLjM0LjEKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtcm9ja2NoaXAK