Re: [cip-dev] [PATCH for 5.10.y] phy: renesas: rcar-gen3-usb2: Fix the use of msleep during spinlock

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, May 05, 2026 at 11:49:24AM +0300, Claudiu Beznea wrote:
> 
> 
> On 5/5/26 11:40, Claudiu Beznea wrote:
> > Hi, all,
> > 
> > On 5/4/26 12:18, Pavel Machek via lists.cip-project.org wrote:
> > > Hi!
> > > 
> > > > From: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> > > > 
> > > > This fixes an issue caused by the use of msleep during spinlock.
> > > > In the original commit, msleep was changed to mdelay, but this fix was not
> > > > carried over during the backport to 5.10.y tree.
> > > 
> > > Doing this as a quick fix is probably okay, but this should not be
> > > final version.
> > > 
> > > You are right that msleep inside spinlock will blow up immediately:
> > > 
> > > > ```
> > > > [   62.677594] BUG: scheduling while atomic: kworker/1:2/126/0x00000002
> > > > [   62.683957] Modules linked in:
> > > 
> > > But mdelay for 20 msec inside irqsave spinlock is borderline
> > > unacceptable, too.
> > > 
> > > I believe we'll need Renesas to analyze/fix this properly after the
> > > CVE emergency is done.
> > > 
> > > This fix is good for now, but better fix is needed.
> > > 
> > > Claudiu, are you right person for this, or should we cc someone else?
> > 
> > I'm going to investigate and come with a better approach for this.
> 
> On a second thought, the proper fix would have to go to upstream first. To
> fix the problem currently seen, could we integrate this patch as is?

No, please work upstream first.