From: Jamin Lin <jamin_lin@aspeedtech.com>
To: "philmd@linaro.org" <philmd@linaro.org>,
"peterx@redhat.com" <peterx@redhat.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Kane Chen" <kane_chen@aspeedtech.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: Jamin Lin <jamin_lin@aspeedtech.com>,
Troy Lee <troy_lee@aspeedtech.com>,
"farosas@suse.de" <farosas@suse.de>,
"flwu@google.com" <flwu@google.com>,
"nabihestefan@google.com" <nabihestefan@google.com>
Subject: [PATCH v1 2/2] hw/usb/hcd-ehci: Rename CTRLDSSEGMENT default property
Date: Wed, 6 May 2026 03:26:45 +0000 [thread overview]
Message-ID: <20260506032643.2510575-3-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20260506032643.2510575-1-jamin_lin@aspeedtech.com>
Rename the EHCI CTRLDSSEGMENT default property and
internal field to improve readability.
No functional change.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
hw/usb/hcd-ehci.h | 6 +++---
hw/arm/aspeed_ast27x0.c | 2 +-
hw/usb/hcd-ehci.c | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h
index b5ac9c8670..b739c81870 100644
--- a/hw/usb/hcd-ehci.h
+++ b/hw/usb/hcd-ehci.h
@@ -268,7 +268,7 @@ struct EHCIState {
*/
bool migrate_fetch_addr_64bit;
bool caps_64bit_addr;
- uint32_t ctrldssegment_default;
+ uint32_t ctrl_ds_segment_default;
/*
* EHCI spec version 1.0 Section 2.3
@@ -335,8 +335,8 @@ struct EHCIState {
ehci.migrate_fetch_addr_64bit, true), \
DEFINE_PROP_BOOL("caps-64bit-addr", _state, \
ehci.caps_64bit_addr, false), \
- DEFINE_PROP_UINT32("ctrldssegment-default", _state, \
- ehci.ctrldssegment_default, 0)
+ DEFINE_PROP_UINT32("ctrl-ds-segment-default", _state, \
+ ehci.ctrl_ds_segment_default, 0)
extern const VMStateDescription vmstate_ehci;
diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c
index a8f0bc389c..5865894658 100644
--- a/hw/arm/aspeed_ast27x0.c
+++ b/hw/arm/aspeed_ast27x0.c
@@ -856,7 +856,7 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, Error **errp)
/* EHCI */
for (i = 0; i < sc->ehcis_num; i++) {
- object_property_set_int(OBJECT(&s->ehci[i]), "ctrldssegment-default",
+ object_property_set_int(OBJECT(&s->ehci[i]), "ctrl-ds-segment-default",
sc->memmap[ASPEED_DEV_SDRAM] >> 32,
&error_abort);
object_property_set_bool(OBJECT(&s->ehci[i]), "caps-64bit-addr", true,
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index 56ac8f6ae5..133501b0f4 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -1134,7 +1134,7 @@ static void ehci_opreg_write(void *ptr, hwaddr addr,
"64-bit addressing capability is disabled\n");
return;
}
- val |= s->ctrldssegment_default;
+ val |= s->ctrl_ds_segment_default;
break;
case ASYNCLISTADDR:
--
2.43.0
next prev parent reply other threads:[~2026-05-06 3:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 3:26 [PATCH v1 0/2] hw/usb/ehci: Improve migration helper and property naming Jamin Lin
2026-05-06 3:26 ` [PATCH v1 1/2] hw/usb/hcd-ehci: Rename migration compatibility fetch address fields Jamin Lin
2026-05-06 9:10 ` Philippe Mathieu-Daudé
2026-05-09 16:10 ` Cédric Le Goater
2026-05-06 3:26 ` Jamin Lin [this message]
2026-05-09 15:55 ` [PATCH v1 2/2] hw/usb/hcd-ehci: Rename CTRLDSSEGMENT default property Cédric Le Goater
2026-05-08 13:35 ` [PATCH v1 0/2] hw/usb/ehci: Improve migration helper and property naming Philippe Mathieu-Daudé
2026-05-09 16:00 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506032643.2510575-3-jamin_lin@aspeedtech.com \
--to=jamin_lin@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=farosas@suse.de \
--cc=flwu@google.com \
--cc=joel@jms.id.au \
--cc=kane_chen@aspeedtech.com \
--cc=leetroy@gmail.com \
--cc=nabihestefan@google.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.