Re: [PULL 0/2] Build system: add stubs per target

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 3535 bytes --]

On Wed, May 06, 2026 at 05:16:21PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Stefan, Pierrick,
> 
> On Wed, 6 May 2026 at 16:42, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> >
> > On Tue, May 5, 2026 at 7:07 PM Pierrick Bouvier
> > <pierrick.bouvier@oss.qualcomm.com> wrote:
> > >
> > > The following changes since commit a85c588d07f8d3345ccad38b22026569a04571d1:
> > >
> > >   Merge tag 'pull-monitor-2026-05-05' of https://repo.or.cz/qemu/armbru into staging (2026-05-05 10:11:49 -0400)
> > >
> > > are available in the Git repository at:
> > >
> > >   https://gitlab.com/p-b-o/qemu tags/pbouvier/pr/build_system-20260505
> > >
> > > for you to fetch changes up to 2e44ff32fc758bf8c0df13b0287afb75bb00c38e:
> > >
> > >   target/arm: define stub library (2026-05-05 16:06:00 -0700)
> > >
> > > ----------------------------------------------------------------
> > > Changes:
> > > - [PATCH 0/2] single-binary: add stubs for target/ (Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>)
> > >   Link: https://lore.kernel.org/qemu-devel/20260424230103.1579600-1-pierrick.bouvier@oss.qualcomm.com
> > >
> > > ----------------------------------------------------------------
> > > Pierrick Bouvier (2):
> > >       meson.build: define stubs library per target base architecture
> > >       target/arm: define stub library
> > >
> > >  meson.build                | 22 +++++++++++++++++++---
> > >  target/arm/meson.build     |  8 +++-----
> > >  target/arm/tcg/meson.build |  2 +-
> > >  3 files changed, 23 insertions(+), 9 deletions(-)
> >
> > Is this a pull request for Paolo's build system tree?
> >
> > I'm not merging this directly because I prefer to follow MAINTAINERS
> > so it's clear who sends pull requests for each subsystem. That way
> > maintainers won't be surprised by me merging a pull request from
> > another contributor who is not officially the maintainer and it's also
> > better for security.
> 
> I did not notice Pierrick's PR and actually included these 2
> commits in my latest "single-binary" pull request:
> https://lore.kernel.org/qemu-devel/20260506135524.20617-1-philmd@linaro.org/

That can be fine, sometimes changes are cross-cutting or part of another
sub-system (e.g. ARM target) even though they touch files a different
subsystem.

My concern is only about the pull request process. Please don't send
pull requests with a new tag/branch name that is not in MAINTAINERS. No
PR has ever been merged from Pierrick with a build_system-* tag and he
is not listed in MAINTAINERS for Build System.

This could be a sign that something in MAINTAINERS needs to be changed
or it could be a sign that these patches should go through another tree
(Paolo's or yours).

> Pierrick and I are simply reviewers on the "Build System" topic,
> but it happens that I send patches there where they are related to
> the overall single binary objective, and I see Pierrick as a co-maintainer
> in this area. However there is no clearly defined MAINTAINERS
> section, we happen to touch build system related files all over
> the tree.

I can't accept random pull requests, even from regular contributors.
Patches should go through subsystem maintainers listed in the
MAINTAINERS file. This way we can be sure that only commits reviewed by
a subsystem maintainers are merged and reduce the risk that malicious
pull requests are merged (while I trust Pierrick, it lowers my guard if
I'm accepting random pull requests from anyone at all).

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]