All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: "Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nicolas Schier" <nsc@kernel.org>,
	"Saravana Kannan" <saravanak@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Masahiro Yamada" <masahiroy@kernel.org>,
	"Thomas Weißschuh" <linux@weissschuh.net>,
	"Tamir Duberstein" <tamird@kernel.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Aleksander Jan Bajkowski" <olek2@wp.pl>,
	"Test User" <test@example.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: add self-test fixtures for style checker
Date: Wed, 6 May 2026 13:36:18 -0500	[thread overview]
Message-ID: <20260506183618.GB2178335-robh@kernel.org> (raw)
In-Reply-To: <4b913d4e903c56ac479a4f3715159d63ea5cdcea.1777471439.git.daniel@makrotopia.org>

On Wed, Apr 29, 2026 at 03:21:39PM +0100, Daniel Golle wrote:
> Provide good/ and bad/ DTS and YAML fixtures plus a small runner that
> feeds them to dt-check-style and diffs the output against expected
> text files. Wired into a new top-level dt_style_selftest make target
> so the suite can be exercised independently of the full tree.
> 
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> Changes since v1:
>  - new patch (Krzysztof: "would be happy to see at least a few test
>    cases for it")
> 
>  Makefile                                      |  6 ++
>  .../dtc/dt-style-selftest/bad/dts-spaces.dts  | 13 ++++
>  .../bad/yaml-child-addr-order.yaml            | 41 ++++++++++++
>  .../bad/yaml-child-name-order.yaml            | 37 ++++++++++
>  .../bad/yaml-cont-align.yaml                  | 30 +++++++++
>  .../dt-style-selftest/bad/yaml-hex-case.yaml  | 29 ++++++++
>  .../bad/yaml-indent-strict.yaml               | 29 ++++++++
>  .../bad/yaml-line-length.yaml                 | 29 ++++++++
>  .../bad/yaml-mixed-indent.yaml                | 29 ++++++++
>  .../bad/yaml-node-close.yaml                  | 31 +++++++++
>  .../bad/yaml-prop-order.yaml                  | 29 ++++++++
>  .../bad/yaml-prop-pairing.yaml                | 33 +++++++++
>  .../bad/yaml-required-blank.yaml              | 33 +++++++++
>  .../dtc/dt-style-selftest/bad/yaml-tab.yaml   | 29 ++++++++
>  .../bad/yaml-trailing-ws.yaml                 | 29 ++++++++
>  .../dt-style-selftest/bad/yaml-unit-addr.yaml | 29 ++++++++
>  .../bad/yaml-unused-label.yaml                | 29 ++++++++
>  .../dt-style-selftest/bad/yaml-value-ws.yaml  | 29 ++++++++
>  .../expected/dts-spaces.dts.txt               |  2 +
>  .../expected/yaml-child-addr-order.yaml.txt   |  2 +
>  .../expected/yaml-child-name-order.yaml.txt   |  2 +
>  .../expected/yaml-cont-align.yaml.txt         |  2 +
>  .../expected/yaml-hex-case.yaml.txt           |  2 +
>  .../expected/yaml-indent-strict.yaml.txt      |  2 +
>  .../expected/yaml-line-length.yaml.txt        |  2 +
>  .../expected/yaml-mixed-indent.yaml.txt       |  3 +
>  .../expected/yaml-node-close.yaml.txt         |  2 +
>  .../expected/yaml-prop-order.yaml.txt         |  2 +
>  .../expected/yaml-prop-pairing.yaml.txt       |  3 +
>  .../expected/yaml-required-blank.yaml.txt     |  3 +
>  .../expected/yaml-tab.yaml.txt                |  2 +
>  .../expected/yaml-trailing-ws.yaml.txt        |  2 +
>  .../expected/yaml-unit-addr.yaml.txt          |  2 +
>  .../expected/yaml-unused-label.yaml.txt       |  2 +
>  .../expected/yaml-value-ws.yaml.txt           |  2 +

All these .txt files need a newline at the end.

>  .../dtc/dt-style-selftest/good/dts-tab.dts    | 30 +++++++++
>  .../dt-style-selftest/good/yaml-4space.yaml   | 41 ++++++++++++
>  scripts/dtc/dt-style-selftest/run.sh          | 67 +++++++++++++++++++
>  38 files changed, 689 insertions(+)

      reply	other threads:[~2026-05-06 18:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29 14:21 [PATCH v2 0/3] dt-bindings: automated coding style check for DTS examples Daniel Golle
2026-04-29 14:21 ` [PATCH v2 1/3] dt-bindings: add DTS style checker Daniel Golle
2026-05-06 18:33   ` Rob Herring
2026-04-29 14:21 ` [PATCH v2 2/3] dt-bindings: wire style checker into dt_binding_check Daniel Golle
2026-04-30 23:13   ` Nathan Chancellor
2026-05-06 18:44   ` Rob Herring
2026-05-07  9:26     ` Nathan Chancellor
2026-05-07 17:00       ` Rob Herring
2026-05-08 12:23         ` Nathan Chancellor
2026-04-29 14:21 ` [PATCH v2 3/3] dt-bindings: add self-test fixtures for style checker Daniel Golle
2026-05-06 18:36   ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260506183618.GB2178335-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel@makrotopia.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=linux@weissschuh.net \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nsc@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=olek2@wp.pl \
    --cc=rostedt@goodmis.org \
    --cc=saravanak@kernel.org \
    --cc=tamird@kernel.org \
    --cc=test@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.