From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: mike.marciniszyn@gmail.com,
Alexander Duyck <alexanderduyck@fb.com>,
kernel-team@meta.com, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Jacob Keller <jacob.e.keller@intel.com>,
Mohsin Bashir <mohsin.bashr@gmail.com>,
Simon Horman <horms@kernel.org>, Lee Trager <lee@trager.us>,
Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/4] net: eth: fbnic: Fix addr validation in pcs write
Date: Wed, 6 May 2026 18:58:19 -0700 [thread overview]
Message-ID: <20260506185819.1c68a71b@kernel.org> (raw)
In-Reply-To: <20260504135815.44226-2-mike.marciniszyn@gmail.com>
On Mon, 4 May 2026 09:58:12 -0400 mike.marciniszyn@gmail.com wrote:
> From: "Mike Marciniszyn (Meta)" <mike.marciniszyn@gmail.com>
>
> The DW IP has two distinct PCS address ranges cooresponding
> to the C45 PCS registers.
>
> The shim translates the PCS addr/regno into specific CSR writes
> into one of those two zero-relative.
>
> This patch fixes a one off in the test that could allow an invalid
> CSR write if an addr == 2 was called.
>
> This patch contains a fix for addr validation in fbnic_mdio_write_pcs()
> to only return actual CSR reads for addr 0 and 1.
>
> There are as of yet, no real impact for the bug as no PCS writes are
> not yet present.
Hi Paolo! Was there a reason / do you recall why this was not applied?
(I dropped it from patchwork now. If the omission was accidental it has
to be reposted)
next prev parent reply other threads:[~2026-05-07 1:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 13:58 [PATCH net-next v3 0/4] irst series for xpcs based rsfec configuration mike.marciniszyn
2026-05-04 13:58 ` [PATCH net-next v3 1/4] net: eth: fbnic: Fix addr validation in pcs write mike.marciniszyn
2026-05-07 1:58 ` Jakub Kicinski [this message]
2026-05-07 7:20 ` Paolo Abeni
2026-05-07 13:20 ` Mike Marciniszyn
2026-05-07 13:48 ` Mike Marciniszyn
2026-05-07 13:50 ` Paolo Abeni
2026-05-07 15:58 ` Mike Marciniszyn
2026-05-04 13:58 ` [PATCH net-next v3 2/4] net: mdio: Add support for RSFEC Control register for PMA mike.marciniszyn
2026-05-04 13:58 ` [PATCH net-next v3 3/4] net: eth: fbnic: Consolidate register reads for ids and devs mike.marciniszyn
2026-05-04 13:58 ` [PATCH net-next v3 4/4] net: eth: fbnic: Add pma read and write access mike.marciniszyn
2026-05-05 12:50 ` [PATCH net-next v3 0/4] irst series for xpcs based rsfec configuration patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506185819.1c68a71b@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kernel-team@meta.com \
--cc=lee@trager.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mike.marciniszyn@gmail.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.