From: Christoph Hellwig <hch@lst.de>
To: Chao Shi <coshi036@gmail.com>
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@kernel.dk,
Sungwoo Kim <iam@sung-woo.kim>, Dave Tian <daveti@purdue.edu>,
Weidong Zhu <weizhu@fiu.edu>
Subject: Re: [PATCH RFC 2/2] nvme: set integrity metadata size for EXT_LBAS non-PI namespace
Date: Thu, 7 May 2026 07:49:44 +0200 [thread overview]
Message-ID: <20260507054944.GB19796@lst.de> (raw)
In-Reply-To: <20260427003457.1264511-2-coshi036@gmail.com>
On Sun, Apr 26, 2026 at 08:34:57PM -0400, Chao Shi wrote:
> + /*
> + * For PCIe EXT_LBAS non-PI namespaces the block layer sets
> + * capacity to 0 (we return false) to prevent block I/O, but a
> + * cached-rq bio may bypass bio_queue_enter freeze serialisation
> + * and reach nvme_setup_rw() with head->ms != 0 and no
> + * REQ_INTEGRITY set. Populate bi->metadata_size so that
> + * bio_integrity_action() returns non-zero and bio_integrity_prep()
> + * sets REQ_INTEGRITY on any such bio, preventing the WARN_ON_ONCE
> + * at nvme_setup_rw() (addressed by patch 1/2).
This sounds like the Bug Keith is trying to fix in the block layer
("blk-mq: check for stale cached request in blk_mq_submit_bio") ?
next prev parent reply other threads:[~2026-05-07 5:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 0:34 [PATCH RFC 1/2] nvme: downgrade WARN in nvme_setup_rw to pr_debug Chao Shi
2026-04-27 0:34 ` [PATCH RFC 2/2] nvme: set integrity metadata size for EXT_LBAS non-PI namespace Chao Shi
2026-05-07 5:49 ` Christoph Hellwig [this message]
2026-05-07 8:05 ` Keith Busch
2026-05-07 5:48 ` [PATCH RFC 1/2] nvme: downgrade WARN in nvme_setup_rw to pr_debug Christoph Hellwig
2026-05-17 3:54 ` Chao S
2026-05-18 5:56 ` Christoph Hellwig
2026-05-07 18:12 ` Keith Busch
2026-05-17 3:53 ` Chao S
2026-05-17 22:05 ` Keith Busch
2026-05-17 22:42 ` Keith Busch
2026-05-18 22:41 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260507054944.GB19796@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=coshi036@gmail.com \
--cc=daveti@purdue.edu \
--cc=iam@sung-woo.kim \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=weizhu@fiu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.