Re: [PATCH v8 phy-next 30/31] phy: remove temporary provider compatibility from consumer header

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] include/linux/phy/phy.h becomes non-self-contained due to missing <linux/err.h> inclusion.
--

commit 84b3f602007ce4ccbcbb1ef2bc28094bd50acb5c
Author: Vladimir Oltean <vladimir.oltean@nxp.com>

phy: remove temporary provider compatibility from consumer header

This commit hides the definition of struct phy from public view by removing
the inclusion of phy-provider.h from the consumer header phy.h.

> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
> index e65865b4acfe5..ccf7e83f103ae 100644
> --- a/include/linux/phy/phy.h
> +++ b/include/linux/phy/phy.h
> @@ -12,8 +12,6 @@
>  
>  #include <linux/phy/phy-props.h>
>  
> -#include "../../../drivers/phy/phy-provider.h"

Does removing this inclusion also remove the implicit inclusion of
linux/err.h?

The fallback inline functions in phy.h (used when CONFIG_GENERIC_PHY is
disabled) rely on ERR_PTR, -ENOSYS, and -ENODEV. Without an explicit
inclusion of linux/err.h, this header may no longer be self-contained for
consumers when CONFIG_GENERIC_PHY is disabled.

> -
>  struct device;
>  struct device_node;
>  struct phy;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260505100523.1922388-1-vladimir.oltean@nxp.com?part=30