From: Lee Jones <lee@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
"Lukasz Luba" <lukasz.luba@arm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Bartlomiej Zolnierkiewicz" <bzolnier@gmail.com>,
"Kees Cook" <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"Peter Griffin" <peter.griffin@linaro.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Daniel Lezcano" <daniel.lezcano@kernel.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
willmcvicker@google.com, jyescas@google.com,
shin.son@samsung.com, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-hardening@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 03/10] firmware: samsung: acpm: Drop redundant _ops suffix in acpm_ops members
Date: Thu, 7 May 2026 13:00:03 +0100 [thread overview]
Message-ID: <20260507120003.GG305027@google.com> (raw)
In-Reply-To: <20260420-acpm-tmu-v3-3-3dc8e93f0b26@linaro.org>
On Mon, 20 Apr 2026, Tudor Ambarus wrote:
> Rename the `dvfs_ops` and `pmic_ops` members of `struct acpm_ops` to
> `dvfs` and `pmic` respectively.
>
> Since these members are housed within the `acpm_ops` structure and
> utilize the `acpm_*_ops` types, the `_ops` suffix on the variable names
> creates unnecessary redundancy (e.g., `handle.ops.dvfs_ops`).
>
> This cleanup removes the stuttering, leading to cleaner consumer code.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> drivers/clk/samsung/clk-acpm.c | 8 ++++----
> drivers/firmware/samsung/exynos-acpm.c | 4 ++--
> drivers/mfd/sec-acpm.c | 6 +++---
Acked-by: Lee Jones <lee@kernel.org>
> include/linux/firmware/samsung/exynos-acpm-protocol.h | 4 ++--
> 4 files changed, 11 insertions(+), 11 deletions(-)
--
Lee Jones
next prev parent reply other threads:[~2026-05-07 12:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 17:39 [PATCH v3 00/10] thermal: samsung: Add support for Google GS101 TMU Tudor Ambarus
2026-04-20 17:39 ` [PATCH v3 01/10] dt-bindings: thermal: Add " Tudor Ambarus
2026-04-20 17:39 ` [PATCH v3 02/10] firmware: samsung: acpm: Consolidate transfer initialization helper Tudor Ambarus
2026-04-20 17:39 ` [PATCH v3 03/10] firmware: samsung: acpm: Drop redundant _ops suffix in acpm_ops members Tudor Ambarus
2026-05-07 12:00 ` Lee Jones [this message]
2026-05-15 9:05 ` Tudor Ambarus
2026-04-20 17:39 ` [PATCH v3 04/10] firmware: samsung: acpm: Make acpm_ops const and access via pointer Tudor Ambarus
2026-04-20 17:39 ` [PATCH v3 05/10] firmware: samsung: acpm: Add TMU protocol support Tudor Ambarus
2026-04-20 17:39 ` [PATCH v3 06/10] firmware: samsung: acpm: Add devm_acpm_get_by_phandle helper Tudor Ambarus
2026-04-20 17:39 ` [PATCH v3 07/10] thermal: samsung: Add Exynos ACPM TMU driver GS101 Tudor Ambarus
2026-04-20 17:39 ` [PATCH v3 08/10] MAINTAINERS: Add entry for Samsung Exynos ACPM thermal driver Tudor Ambarus
2026-04-20 17:39 ` [PATCH v3 09/10] arm64: dts: exynos: gs101: Add thermal management unit Tudor Ambarus
2026-04-20 17:39 ` [PATCH v3 10/10] arm64: defconfig: enable Exynos ACPM thermal support Tudor Ambarus
2026-04-23 12:34 ` [PATCH v3 00/10] thermal: samsung: Add support for Google GS101 TMU Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260507120003.GG305027@google.com \
--to=lee@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=bzolnier@gmail.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=daniel.lezcano@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavoars@kernel.org \
--cc=jyescas@google.com \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=shin.son@samsung.com \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.