All of lore.kernel.org
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Ricardo Branco <rbranco@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] memfd_create: move sys_memfd_create() to lapi/memfd.h
Date: Thu,  7 May 2026 18:32:27 +0000	[thread overview]
Message-ID: <20260507183227.4098-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260507181045.19489-1-rbranco@suse.de>

Hi Ricardo,

--- [PATCH 1/2] ---

On 2026-05-07, Ricardo Branco wrote:
> memfd_create: move sys_memfd_create() to lapi/memfd.h
>
> Add the static inline wrapper to include/lapi/memfd.h and include the
> required headers so other tests can reuse it.
>
> Also fix some minor issues detected by make check.

The "also fix" indicates a second logical change bundled in. Please split
the minor cleanup fixes (blank line in memfd_create01.c, trailing semicolon
in CHECK_MFD_HAS_SEALS) into a separate commit so each patch contains
exactly one logical change.

> -	check_mfd_has_seals(__FILE__, __LINE__, (fd), (seals));
> +	check_mfd_has_seals(__FILE__, __LINE__, (fd), (seals))

This fix is independent of the sys_memfd_create() move — separate commit.

Pre-existing issues noticed in the surrounding code (not introduced
by this patch):

- include/lapi/memfd.h (pre-patch) — file relied on callers to pull in
  tst_test.h and lapi/syscalls.h transitively; now correctly self-contained.

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://github.com/linux-test-project/ltp-agent/actions/runs/25514269891

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2026-05-07 18:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07 18:10 [LTP] [PATCH v7 1/2] memfd_create: move sys_memfd_create() to lapi/memfd.h Ricardo Branco
2026-05-07 18:10 ` [LTP] [PATCH v7 2/2] userfaultfd: Add new test using UFFDIO_CONTINUE Ricardo Branco
2026-05-12 12:45   ` Cyril Hrubis
2026-05-07 18:32 ` linuxtestproject.agent [this message]
2026-05-12 11:49 ` [LTP] [PATCH v7 1/2] memfd_create: move sys_memfd_create() to lapi/memfd.h Cyril Hrubis
  -- strict thread matches above, loose matches on Subject: below --
2026-04-11  9:47 [LTP] [PATCH v6 " Ricardo Branco
2026-04-11 10:44 ` [LTP] " acervesato
2026-05-05 12:24   ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260507183227.4098-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=ltp@lists.linux.it \
    --cc=rbranco@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.