Re: [PATCH v2 7/9] Bluetooth: hci_qca: Rename 'power_ctrl_enabled' to 'bt_en_available'

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The rename of 'power_ctrl_enabled' to 'bt_en_available' introduces a misleading semantic mismatch and contradicts the commit message.
--

commit ebe40bb62789f8cbdbd8baa6c8be848d58c9f72b
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>

Bluetooth: hci_qca: Rename 'power_ctrl_enabled' to 'bt_en_available'

This commit renames the power_ctrl_enabled flag to bt_en_available in
qca_serdev_probe(), with the commit message stating that the flag only
indicates the availability of the BT_EN GPIO.

> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
[ ... ]
> @@ -2391,7 +2391,7 @@ static int qca_serdev_probe(struct serdev_device *serdev)
>  	struct hci_dev *hdev;
>  	const struct qca_device_data *data;
>  	int err;
> -	bool power_ctrl_enabled = true;
> +	bool bt_en_available = true;

Is the description in the commit message accurate?

Looking at qca_serdev_probe(), there are several paths where the BT_EN GPIO
is not present, but this flag remains true. For example, with a QCA_WCN3990
device, qcadev->bt_en can be NULL. Since it doesn't match the specific
SoC types in the checks below, bt_en_available is never set to false:

qca_serdev_probe() {
        ...
        qcadev->bt_en = devm_gpiod_get_optional(&serdev->dev, "enable",
                                       GPIOD_OUT_LOW);
        ...
        if (!qcadev->bt_en &&
            (data->soc_type == QCA_WCN6750 ||
             data->soc_type == QCA_WCN6855 ||
             data->soc_type == QCA_WCN7850))
                bt_en_available = false;
        ...
}

The original power_ctrl_enabled flag tracked whether any driver-managed
power control (such as regulators or a generic power sequencer) was
available, ensuring the qca_hci_shutdown callback is registered.

Does renaming this generic power control flag to bt_en_available introduce
a mismatch where bt_en_available is true while qcadev->bt_en is NULL,
potentially confusing future modifications?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260507-pwrseq-m2-bt-v2-0-1740bd478539@oss.qualcomm.com?part=7