All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Hyunwoo Kim <imv4bel@gmail.com>
Cc: Qingfang Deng <qingfang.deng@linux.dev>,
	dhowells@redhat.com, marc.dionne@auristor.com,
	davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	horms@kernel.org, linux-afs@lists.infradead.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH net] rxrpc: Also unshare DATA/RESPONSE packets when paged frags are present
Date: Fri, 8 May 2026 13:25:32 -0700	[thread overview]
Message-ID: <20260508132532.2008a68f@kernel.org> (raw)
In-Reply-To: <af19tf9gX3sxIrWr@v4bel>

On Fri, 8 May 2026 15:07:49 +0900 Hyunwoo Kim wrote:
> > > -	if (skb_cloned(skb)) {
> > > +	if (skb_cloned(skb) || skb->data_len) {  
> > 
> > Ditto.  
> 
> Thank you for the review.

Maybe skb_ensure_writable() ?

  reply	other threads:[~2026-05-08 20:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29 23:35 [PATCH net] rxrpc: Also unshare DATA/RESPONSE packets when paged frags are present Hyunwoo Kim
2026-05-01 15:58 ` Simon Horman
2026-05-01 16:57   ` Hyunwoo Kim
2026-05-08  5:57 ` Qingfang Deng
2026-05-08  6:07   ` Hyunwoo Kim
2026-05-08 20:25     ` Jakub Kicinski [this message]
2026-05-09  1:32       ` Qingfang Deng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260508132532.2008a68f@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=imv4bel@gmail.com \
    --cc=linux-afs@lists.infradead.org \
    --cc=marc.dionne@auristor.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=qingfang.deng@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.