From: Jun Yan <jerrysteve1101@gmail.com>
To: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Vincent Knecht <vincent.knecht@mailoo.org>,
Grant Feng <von81@163.com>,
Andre Przywara <andre.przywara@arm.com>,
Heiko Stuebner <heiko@sntech.de>,
Romain Perier <romain.perier@gmail.com>,
Paul Barker <paul.barker@sancloud.com>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Robert Marko <robert.marko@sartura.hr>
Cc: Jun Yan <jerrysteve1101@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Krzysztof Kozlowski <krzk@kernel.org>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Peter Rosin <peda@axentia.se>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] arm64: dts: qcom: msm8916-alcatel-idol347: Fix sn3190 shutdown GPIO polarity
Date: Fri, 8 May 2026 23:24:20 +0800 [thread overview]
Message-ID: <20260508152435.21389-4-jerrysteve1101@gmail.com> (raw)
In-Reply-To: <20260508152435.21389-1-jerrysteve1101@gmail.com>
The sn3190 shutdown pin is active-low [1]. Correct the GPIO flags
from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW to match the hardware.
[1] https://lumissil.com/assets/pdf/core/IS31FL3190_DS.pdf
Fixes: 1c8cc183d070 ("arm64: dts: qcom: msm8916-alcatel-idol347: add LED indicator")
Signed-off-by: Jun Yan <jerrysteve1101@gmail.com>
---
arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
index 2de8b6f9531b..6d51d6efcbac 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
@@ -197,7 +197,7 @@ &blsp_i2c6 {
led-controller@68 {
compatible = "si-en,sn3190";
reg = <0x68>;
- shutdown-gpios = <&tlmm 89 GPIO_ACTIVE_HIGH>;
+ shutdown-gpios = <&tlmm 89 GPIO_ACTIVE_LOW>;
pinctrl-names = "default";
pinctrl-0 = <&led_enable_default &led_shutdown_default>;
#address-cells = <1>;
--
2.54.0
next prev parent reply other threads:[~2026-05-08 15:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 15:24 [PATCH 0/5] leds: is31fl319x: Fix shutdown GPIO and update DT bindings Jun Yan
2026-05-08 15:24 ` [PATCH 1/5] dt-bindings: leds: issi,is31fl319x: Add description for the shutdown-gpios property Jun Yan
2026-05-13 23:26 ` Rob Herring (Arm)
2026-05-08 15:24 ` [PATCH 2/5] leds: is31fl319x: Fix shutdown GPIO initial state and remove redundant startup pulse Jun Yan
2026-05-11 9:10 ` Linus Walleij
2026-05-13 14:44 ` Jun Yan
2026-05-13 15:54 ` Dmitry Baryshkov
2026-05-08 15:24 ` Jun Yan [this message]
2026-05-14 10:58 ` [PATCH 3/5] arm64: dts: qcom: msm8916-alcatel-idol347: Fix sn3190 shutdown GPIO polarity Konrad Dybcio
2026-05-08 15:24 ` [PATCH 4/5] ARM: dts: qcom: msm8974-oneplus-bacon: Fix sn3193 " Jun Yan
2026-05-14 10:58 ` Konrad Dybcio
2026-05-08 15:24 ` [PATCH 5/5] arm64: dts: marvell: armada-7040-mochabin: Fix is31fl3199 " Jun Yan
2026-05-13 15:56 ` [PATCH 0/5] leds: is31fl319x: Fix shutdown GPIO and update DT bindings Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508152435.21389-4-jerrysteve1101@gmail.com \
--to=jerrysteve1101@gmail.com \
--cc=andersson@kernel.org \
--cc=andre.przywara@arm.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=heiko@sntech.de \
--cc=jesper.nilsson@axis.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=patrice.chotard@foss.st.com \
--cc=paul.barker@sancloud.com \
--cc=pavel@kernel.org \
--cc=pavel@ucw.cz \
--cc=peda@axentia.se \
--cc=robert.marko@sartura.hr \
--cc=robh@kernel.org \
--cc=romain.perier@gmail.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=vincent.knecht@mailoo.org \
--cc=von81@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.