Re: [PATCH 1/3] arm64: dts: qcom: kaanapali: Add camss node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit adds a new compatible string 'qcom,kaanapali-camss' without providing the corresponding YAML device tree binding schema.
--

commit a3fc6582c63ecf6be414df632ff7d8a517115d29
Author: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>

arm64: dts: qcom: kaanapali: Add camss node

This commit adds the camss device tree node for the Kaanapali camera
subsystem, defining its registers, clocks, interrupts, interconnects,
and power domains.

> diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dts/qcom/kaanapali.dtsi
> index 7cc326aa1a1aa..9d8aee202797f 100644
> --- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi
> +++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi
> @@ -3138,6 +3138,207 @@ opp-202000000 {
>  			};
>  		};
>  
> +		camss: isp@9253000 {
> +			compatible = "qcom,kaanapali-camss";

Is there a corresponding YAML device tree binding patch for this new
compatible string?

Without the binding schema for qcom,kaanapali-camss, dt_binding_check
cannot validate the hardware description. Should the schema be included
in this patch series to ensure the node properties can be verified?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508-knp-camera-v1-0-a18e289163fd@oss.qualcomm.com?part=1