From: David Sterba <dsterba@suse.cz>
To: Illia Bobyr <illia.bobyr@gmail.com>
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH] btrfs-progs: balance: most filters can only be specified once
Date: Fri, 8 May 2026 22:42:46 +0200 [thread overview]
Message-ID: <20260508204246.GF2558453@twin.jikos.cz> (raw)
In-Reply-To: <20260408082200.788451-1-illia.bobyr@gmail.com>
On Wed, Apr 08, 2026 at 01:21:53AM -0700, Illia Bobyr wrote:
> Clarify in the documentation that only one occurrence of most filters is
> actually processed. Add a warning when more than one filter of the same
> type is specified.
>
> It would be better to show an error when the same filter is specified
> more than once. The first filter is ignore in this case, and this is
> not an expected behavior - nor from the existing documentation, nor from
> a "naive" understand of the filter syntax. But as there could be
> existing scripts that may be specifying the same filter more than once,
> it is probably safer to show a warning and turn this into an error at a
> later point in time. Giving everyone time to update their scripts.
>
> Signed-off-by: Illia Bobyr <illia.bobyr@gmail.com>
Added to devel, thanks.
prev parent reply other threads:[~2026-05-08 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 8:21 [PATCH] btrfs-progs: balance: most filters can only be specified once Illia Bobyr
2026-05-08 20:42 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508204246.GF2558453@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=illia.bobyr@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.