All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jun Yan" <jerrysteve1101@gmail.com>
Cc: devicetree@vger.kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v5 1/5] dt-bindings: leds: is31fl32xx: convert the binding to yaml
Date: Fri, 08 May 2026 20:49:14 +0000	[thread overview]
Message-ID: <20260508204915.E99C2C2BCB0@smtp.kernel.org> (raw)
In-Reply-To: <20260508131139.1523597-2-jerrysteve1101@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The YAML binding filename and its `$id` use an incorrect vendor prefix (`issl` instead of `issi`).
--

commit e7636bd58d531019b888ef291c9c0d2fe4fa5e0c
Author: Jun Yan <jerrysteve1101@gmail.com>

dt-bindings: leds: is31fl32xx: convert the binding to yaml
    
Convert leds-is31fl32xx to DT schema format.

> diff --git a/Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml b/Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml
> new file mode 100644
> index 0000000000000..f4a6ef99b4777
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml

This isn't a bug, but there appears to be a typo in the new filename. The
correct vendor prefix for Integrated Silicon Solution, Inc. is issi, but the
filename uses issl.

> @@ -0,0 +1,151 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/issl,is31fl32xx.yaml#

Should this $id URI also be updated to use issi instead of issl to match the
correct vendor prefix used in the compatible strings below?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508131139.1523597-1-jerrysteve1101@gmail.com?part=1

  reply	other threads:[~2026-05-08 20:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08 13:11 [PATCH v5 0/5] leds: Add powerdown gpio for is31fl32xx Jun Yan
2026-05-08 13:11 ` [PATCH v5 1/5] dt-bindings: leds: is31fl32xx: convert the binding to yaml Jun Yan
2026-05-08 20:49   ` sashiko-bot [this message]
2026-05-08 13:11 ` [PATCH v5 2/5] dt-bindings: leds: leds-is31fl32xx: add support for is31fl3236a Jun Yan
2026-05-08 13:11 ` [PATCH v5 3/5] dt-bindings: leds: leds-is31fl32xx: Add powerdown-gpios property Jun Yan
2026-05-08 13:11 ` [PATCH v5 4/5] leds: is31fl32xx: Add powerdown pin to exit hardware shutdown mode Jun Yan
2026-05-08 21:15   ` sashiko-bot
2026-05-20 14:12   ` Lee Jones
2026-05-24 15:28     ` Jun Yan
2026-05-08 13:11 ` [PATCH v5 5/5] leds: is31f132xx: Fix missing brightness_steps for is31f13236 Jun Yan
2026-05-08 21:28   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260508204915.E99C2C2BCB0@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jerrysteve1101@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.