Re: [PATCH] dt-bindings: iio: dds: Add AD9832/AD9835 binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing reference to standard SPI peripheral properties schema restricts valid SPI configurations.
--

commit 05158b905a98b93285ae76fe23056051bd698d9e
Author: Hungyu Lin <dennylin0707@gmail.com>

dt-bindings: iio: dds: Add AD9832/AD9835 binding

This commit adds device tree binding documentation for the AD9832 and
AD9835 SPI-controlled direct digital synthesizers.

> diff --git a/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - avdd-supply
> +  - dvdd-supply
> +
> +unevaluatedProperties: false

Does this binding need a reference to the standard SPI peripheral properties
schema?

Since unevaluatedProperties is set to false without including a reference to
/schemas/spi/spi-peripheral-props.yaml#, standard SPI properties provided by
a board's device tree (such as spi-cpol, spi-cpha, spi-cs-high, or
spi-rx-delay-us) will be incorrectly rejected by dtbs_check.

Should this schema include an allOf block to inherit the common SPI
properties so that different board designs and controller requirements can
be correctly evaluated?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508233730.77834-1-dennylin0707@gmail.com?part=1