Re: [PATCH v2 3/3] arm64: defconfig: Enable drivers for BeagleBadge

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added configurations `CONFIG_SENSORS_SHT4x` and `CONFIG_LEDS_PWM_MULTICOLOR` are not placed in the correct `savedefconfig` sequence.
--

commit 6f7a4afa4cd800dc21fa4233eabb09b5e3390bc1
Author: Judith Mendez <jm@ti.com>

arm64: defconfig: Enable drivers for BeagleBadge

This commit enables several drivers as modules or built-in for the
BeagleBadge device. The enabled drivers include LED PWM Multicolor, MCP SPI
IO Expander, Seven Segment display GPIO, and Temperature Sensor.

> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index d905a0777f939..0e4cf5e01146f 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
[ ... ]
> @@ -764,6 +765,7 @@ CONFIG_SENSORS_MACSMC_HWMON=m
>  CONFIG_SENSORS_LM75=m
>  CONFIG_SENSORS_LM90=m
>  CONFIG_SENSORS_PWM_FAN=m
> +CONFIG_SENSORS_SHT4x=m

This isn't a bug, but was this defconfig updated using make savedefconfig?

Manual insertions can disrupt the canonical Kconfig parsing order. Based on
the definitions in drivers/hwmon/Kconfig, SENSORS_SHT4x is defined after
SENSORS_SL28CPLD and before SENSORS_AMC6821, so its proper canonical
placement would be between those two entries.

>  CONFIG_SENSORS_RASPBERRYPI_HWMON=m
>  CONFIG_SENSORS_SL28CPLD=m
>  CONFIG_SENSORS_AMC6821=m
[ ... ]
> @@ -1333,6 +1337,7 @@ CONFIG_LEDS_PWM=y
>  CONFIG_LEDS_SYSCON=y
>  CONFIG_LEDS_QCOM_FLASH=m
>  CONFIG_LEDS_QCOM_LPG=m
> +CONFIG_LEDS_PWM_MULTICOLOR=m

Similarly, should CONFIG_LEDS_PWM_MULTICOLOR precede CONFIG_LEDS_QCOM_LPG
to match the order in drivers/leds/rgb/Kconfig?

>  CONFIG_LEDS_TRIGGER_TIMER=y
>  CONFIG_LEDS_TRIGGER_DISK=y
>  CONFIG_LEDS_TRIGGER_HEARTBEAT=y

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508230341.1891450-1-jm@ti.com?part=3